From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E484FC43462 for ; Sat, 15 May 2021 10:30:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFBEF61352 for ; Sat, 15 May 2021 10:30:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231880AbhEOKbe (ORCPT ); Sat, 15 May 2021 06:31:34 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2665 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbhEOKbc (ORCPT ); Sat, 15 May 2021 06:31:32 -0400 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Fj1lt5f3YzNydJ; Sat, 15 May 2021 18:26:50 +0800 (CST) Received: from dggpeml500013.china.huawei.com (7.185.36.41) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Sat, 15 May 2021 18:30:16 +0800 Received: from [10.174.187.161] (10.174.187.161) by dggpeml500013.china.huawei.com (7.185.36.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Sat, 15 May 2021 18:30:15 +0800 Subject: Re: [PATCH v6 00/16] KVM: x86/pmu: Add *basic* support to enable guest PEBS via DS To: Like Xu , Peter Zijlstra , Paolo Bonzini References: <20210511024214.280733-1-like.xu@linux.intel.com> CC: Borislav Petkov , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , , Kan Liang , , , , , , , "Fangyi (Eric)" , Xiexiangyou From: Liuxiangdong Message-ID: <609FA2B7.7030801@huawei.com> Date: Sat, 15 May 2021 18:30:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20210511024214.280733-1-like.xu@linux.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.161] X-ClientProxiedBy: dggeme710-chm.china.huawei.com (10.1.199.106) To dggpeml500013.china.huawei.com (7.185.36.41) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/11 10:41, Like Xu wrote: > A new kernel cycle has begun, and this version looks promising. > > The guest Precise Event Based Sampling (PEBS) feature can provide > an architectural state of the instruction executed after the guest > instruction that exactly caused the event. It needs new hardware > facility only available on Intel Ice Lake Server platforms. This > patch set enables the basic PEBS feature for KVM guests on ICX. > > We can use PEBS feature on the Linux guest like native: > > # perf record -e instructions:ppp ./br_instr a > # perf record -c 100000 -e instructions:pp ./br_instr a Hi, Like. Has the qemu patch been modified? https://lore.kernel.org/kvm/f4dcb068-2ddf-428f-50ad-39f65cad3710@intel.com/ ? > To emulate guest PEBS facility for the above perf usages, > we need to implement 2 code paths: > > 1) Fast path > > This is when the host assigned physical PMC has an identical index as > the virtual PMC (e.g. using physical PMC0 to emulate virtual PMC0). > This path is used in most common use cases. > > 2) Slow path > > This is when the host assigned physical PMC has a different index > from the virtual PMC (e.g. using physical PMC1 to emulate virtual PMC0) > In this case, KVM needs to rewrite the PEBS records to change the > applicable counter indexes to the virtual PMC indexes, which would > otherwise contain the physical counter index written by PEBS facility, > and switch the counter reset values to the offset corresponding to > the physical counter indexes in the DS data structure. > > The previous version [0] enables both fast path and slow path, which > seems a bit more complex as the first step. In this patchset, we want > to start with the fast path to get the basic guest PEBS enabled while > keeping the slow path disabled. More focused discussion on the slow > path [1] is planned to be put to another patchset in the next step. > > Compared to later versions in subsequent steps, the functionality > to support host-guest PEBS both enabled and the functionality to > emulate guest PEBS when the counter is cross-mapped are missing > in this patch set (neither of these are typical scenarios). > > With the basic support, the guest can retrieve the correct PEBS > information from its own PEBS records on the Ice Lake servers. > And we expect it should work when migrating to another Ice Lake > and no regression about host perf is expected. > > Here are the results of pebs test from guest/host for same workload: > > perf report on guest: > # Samples: 2K of event 'instructions:ppp', # Event count (approx.): 1473377250 > # Overhead Command Shared Object Symbol > 57.74% br_instr br_instr [.] lfsr_cond > 41.40% br_instr br_instr [.] cmp_end > 0.21% br_instr [kernel.kallsyms] [k] __lock_acquire > > perf report on host: > # Samples: 2K of event 'instructions:ppp', # Event count (approx.): 1462721386 > # Overhead Command Shared Object Symbol > 57.90% br_instr br_instr [.] lfsr_cond > 41.95% br_instr br_instr [.] cmp_end > 0.05% br_instr [kernel.vmlinux] [k] lock_acquire > Conclusion: the profiling results on the guest are similar tothat on the host. > > A minimum guest kernel version may be v5.4 or a backport version > support Icelake server PEBS. > > Please check more details in each commit and feel free to comment. > > Previous: > https://lore.kernel.org/kvm/20210415032016.166201-1-like.xu@linux.intel.com/ > > [0] https://lore.kernel.org/kvm/20210104131542.495413-1-like.xu@linux.intel.com/ > [1] https://lore.kernel.org/kvm/20210115191113.nktlnmivc3edstiv@two.firstfloor.org/ > > V5 -> V6 Changelog: > - Rebased on the latest kvm/queue tree; > - Fix a git rebase issue (Liuxiangdong); > - Adjust the patch sequence 06/07 for bisection (Liuxiangdong); > > Like Xu (16): > perf/x86/intel: Add EPT-Friendly PEBS for Ice Lake Server > perf/x86/intel: Handle guest PEBS overflow PMI for KVM guest > perf/x86/core: Pass "struct kvm_pmu *" to determine the guest values > KVM: x86/pmu: Set MSR_IA32_MISC_ENABLE_EMON bit when vPMU is enabled > KVM: x86/pmu: Introduce the ctrl_mask value for fixed counter > KVM: x86/pmu: Add IA32_PEBS_ENABLE MSR emulation for extended PEBS > KVM: x86/pmu: Reprogram PEBS event to emulate guest PEBS counter > KVM: x86/pmu: Add IA32_DS_AREA MSR emulation to support guest DS > KVM: x86/pmu: Add PEBS_DATA_CFG MSR emulation to support adaptive PEBS > KVM: x86: Set PEBS_UNAVAIL in IA32_MISC_ENABLE when PEBS is enabled > KVM: x86/pmu: Adjust precise_ip to emulate Ice Lake guest PDIR counter > KVM: x86/pmu: Move pmc_speculative_in_use() to arch/x86/kvm/pmu.h > KVM: x86/pmu: Disable guest PEBS temporarily in two rare situations > KVM: x86/pmu: Add kvm_pmu_cap to optimize perf_get_x86_pmu_capability > KVM: x86/cpuid: Refactor host/guest CPU model consistency check > KVM: x86/pmu: Expose CPUIDs feature bits PDCM, DS, DTES64 > > arch/x86/events/core.c | 5 +- > arch/x86/events/intel/core.c | 129 ++++++++++++++++++++++++------ > arch/x86/events/perf_event.h | 5 +- > arch/x86/include/asm/kvm_host.h | 16 ++++ > arch/x86/include/asm/msr-index.h | 6 ++ > arch/x86/include/asm/perf_event.h | 5 +- > arch/x86/kvm/cpuid.c | 24 ++---- > arch/x86/kvm/cpuid.h | 5 ++ > arch/x86/kvm/pmu.c | 50 +++++++++--- > arch/x86/kvm/pmu.h | 38 +++++++++ > arch/x86/kvm/vmx/capabilities.h | 26 ++++-- > arch/x86/kvm/vmx/pmu_intel.c | 115 +++++++++++++++++++++----- > arch/x86/kvm/vmx/vmx.c | 24 +++++- > arch/x86/kvm/vmx/vmx.h | 2 +- > arch/x86/kvm/x86.c | 14 ++-- > 15 files changed, 368 insertions(+), 96 deletions(-) >