From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2B6C4320A for ; Mon, 26 Jul 2021 06:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A50460E09 for ; Mon, 26 Jul 2021 06:35:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231972AbhGZFzJ (ORCPT ); Mon, 26 Jul 2021 01:55:09 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:12263 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231916AbhGZFzH (ORCPT ); Mon, 26 Jul 2021 01:55:07 -0400 Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GY9512rPvz1CMhl; Mon, 26 Jul 2021 14:29:41 +0800 (CST) Received: from [10.40.166.221] (10.40.166.221) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 26 Jul 2021 14:35:34 +0800 Message-ID: <60FE57B5.2010603@hisilicon.com> Date: Mon, 26 Jul 2021 14:35:33 +0800 From: Wei Xu User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: , , Greg Kroah-Hartman , Rob Herring , Rob Herring , , , , "xuwei (O)" Subject: Re: [PATCH 1/2] dts: hisilicon: add support for the PMIC found on Hikey 970 References: <4a3583dd683512c2a4a138e88d4c889e51bf48e8.1627116285.git.mchehab+huawei@kernel.org> <60FE20AC.3050400@hisilicon.com> <20210726081812.54431189@coco.lan> In-Reply-To: <20210726081812.54431189@coco.lan> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.166.221] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, On 2021/7/26 14:19, Mauro Carvalho Chehab wrote: > Em Mon, 26 Jul 2021 10:40:44 +0800 > Wei Xu escreveu: > >> Hi Mauro, >> >> On 2021/7/24 16:55, Mauro Carvalho Chehab wrote: >>> Add a device tree for the HiSilicon 6421v600 SPMI PMIC, used >>> on HiKey970 board. >>> >>> As we now have support for it, change the fixed regulators >>> used by the SD I/O to use the proper LDO supplies. >>> >>> Signed-off-by: Mauro Carvalho Chehab >>> --- >>> .../boot/dts/hisilicon/hi3670-hikey970.dts | 22 +---- >>> .../boot/dts/hisilicon/hikey970-pmic.dtsi | 86 +++++++++++++++++++ >>> 2 files changed, 89 insertions(+), 19 deletions(-) >>> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts b/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts >>> index d8abf442ee7e..7c32f5fd5cc5 100644 >>> --- a/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts >>> +++ b/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts >>> @@ -12,6 +12,7 @@ >>> >>> #include "hi3670.dtsi" >>> #include "hikey970-pinctrl.dtsi" >>> +#include "hikey970-pmic.dtsi" >>> >>> / { >>> model = "HiKey970"; >>> @@ -39,23 +40,6 @@ memory@0 { >>> reg = <0x0 0x0 0x0 0x0>; >>> }; >>> >>> - sd_1v8: regulator-1v8 { >>> - compatible = "regulator-fixed"; >>> - regulator-name = "fixed-1.8V"; >>> - regulator-min-microvolt = <1800000>; >>> - regulator-max-microvolt = <1800000>; >>> - regulator-always-on; >>> - }; >>> - >>> - sd_3v3: regulator-3v3 { >>> - compatible = "regulator-fixed"; >>> - regulator-name = "fixed-3.3V"; >>> - regulator-min-microvolt = <3300000>; >>> - regulator-max-microvolt = <3300000>; >>> - regulator-boot-on; >>> - regulator-always-on; >>> - }; >>> - >>> wlan_en: wlan-en-1-8v { >>> compatible = "regulator-fixed"; >>> regulator-name = "wlan-en-regulator"; >>> @@ -402,8 +386,8 @@ &dwmmc1 { >>> pinctrl-0 = <&sd_pmx_func >>> &sd_clk_cfg_func >>> &sd_cfg_func>; >>> - vmmc-supply = <&sd_3v3>; >>> - vqmmc-supply = <&sd_1v8>; >>> + vmmc-supply = <&ldo16>; >>> + vqmmc-supply = <&ldo9>; >>> status = "okay"; >>> }; >>> >>> diff --git a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi >>> new file mode 100644 >>> index 000000000000..970047f2dabd >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi >>> @@ -0,0 +1,86 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * dts file for Hi6421v600 SPMI PMIC used at the HiKey970 Development Board >>> + * >>> + * Copyright (C) 2020, Huawei Tech. Co., Ltd. >>> + */ >>> + >>> +#include >>> + >>> +/ { >>> + spmi: spmi@fff24000 { >>> + compatible = "hisilicon,kirin970-spmi-controller"; >>> + #address-cells = <2>; >>> + #size-cells = <0>; >>> + status = "okay"; >>> + reg = <0x0 0xfff24000 0x0 0x1000>; >>> + hisilicon,spmi-channel = <2>; >>> + >>> + pmic: pmic@0 { >>> + compatible = "hisilicon,hi6421-spmi"; >> >> Should this be "hisilicon,hi6421-pmic" which is already in the binding document "mfd/hi6421.txt"? >> Others are OK to me. > > No. > > hisilicon,hi6421-pmic is used by this driver > drivers/mfd/hi6421-pmic-core.c > > which provides support for the Hi6421 variants that don't use a MIPI > SPMI bus. > > The "hisilicon,hi6421-spmi" compatible is for the new driver: > drivers/mfd/hi6421-spmi-pmic.c > > And it is defined at: > Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > > Both DT bindings and the driver were promoted from staging on this patch: > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=9bd9e0de1cf5b89c4854be505ac0a418ddcc01bf Got it. Thanks for your kind explanation! So I am fine with this patch. Do you need my ack now or later I can merge it once it is out of staging. Best Regards, Wei > > Regards, > Mauro > . >