From: "Zhang,Yi" <yi.z.zhang@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, pbonzini@redhat.com,
dan.j.williams@intel.com, hch@lst.de, yu.c.zhang@intel.com,
linux-mm@kvack.org, rkrcmar@redhat.com, yi.z.zhang@intel.com
Subject: Re: [PATCH V2 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX
Date: Wed, 8 Aug 2018 17:22:42 +0800 [thread overview]
Message-ID: <60a42f73-1772-24eb-26f0-efd892b0487c@linux.intel.com> (raw)
In-Reply-To: <20180807091120.ybne44o2fy2mxcch@quack2.suse.cz>
On 2018年08月07日 17:11, Jan Kara wrote:
> On Wed 11-07-18 01:01:59, Zhang Yi wrote:
>> Currently, NVDIMM pages will be marked 'PageReserved'. However, unlike
>> other reserved PFNs, pages on NVDIMM shall still behave like normal ones
>> in many cases, i.e. when used as backend memory of KVM guest. This patch
>> introduces a new memory type, MEMORY_DEVICE_DEV_DAX. And set this flag
>> while dax driver hotplug the device memory.
>>
>> Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
>> Signed-off-by: Zhang Yu <yu.c.zhang@linux.intel.com>
>> ---
>> drivers/dax/pmem.c | 1 +
>> include/linux/memremap.h | 9 +++++++++
>> 2 files changed, 10 insertions(+)
>>
>> diff --git a/drivers/dax/pmem.c b/drivers/dax/pmem.c
>> index fd49b24..fb3f363 100644
>> --- a/drivers/dax/pmem.c
>> +++ b/drivers/dax/pmem.c
>> @@ -111,6 +111,7 @@ static int dax_pmem_probe(struct device *dev)
>> return rc;
>>
>> dax_pmem->pgmap.ref = &dax_pmem->ref;
>> + dax_pmem->pgmap.type = MEMORY_DEVICE_DEV_DAX;
>> addr = devm_memremap_pages(dev, &dax_pmem->pgmap);
>> if (IS_ERR(addr))
>> return PTR_ERR(addr);
>> diff --git a/include/linux/memremap.h b/include/linux/memremap.h
>> index 5ebfff6..a36bce8 100644
>> --- a/include/linux/memremap.h
>> +++ b/include/linux/memremap.h
>> @@ -53,11 +53,20 @@ struct vmem_altmap {
>> * wakeup event whenever a page is unpinned and becomes idle. This
>> * wakeup is used to coordinate physical address space management (ex:
>> * fs truncate/hole punch) vs pinned pages (ex: device dma).
>> + *
>> + * MEMORY_DEVICE_DEV_DAX:
>> + * DAX driver hotplug the device memory and move it to memory zone, these
>> + * pages will be marked reserved flag. However, some other kernel componet
>> + * will misconceive these pages are reserved mmio (ex: we map these dev_dax
>> + * or fs_dax pages to kvm for DIMM/NVDIMM backend). Together with the type
>> + * MEMORY_DEVICE_FS_DAX, we can differentiate the pages on NVDIMM with the
>> + * normal reserved pages.
> So I believe the description should be in terms of what kind of memory is
> the MEMORY_DEVICE_DEV_DAX type, not how users use this type. See comments
> for other memory types...
>
> Honza
Yes, agree, thanks for your kindly review. Jan.
>
>> */
>> enum memory_type {
>> MEMORY_DEVICE_PRIVATE = 1,
>> MEMORY_DEVICE_PUBLIC,
>> MEMORY_DEVICE_FS_DAX,
>> + MEMORY_DEVICE_DEV_DAX,
>> };
>>
>> /*
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2018-08-08 1:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 17:01 [PATCH V2 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-07-10 17:01 ` [PATCH V2 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-07-10 17:01 ` [PATCH V2 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-08-07 9:11 ` Jan Kara
2018-08-08 9:22 ` Zhang,Yi [this message]
2018-07-10 17:02 ` [PATCH V2 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-07-10 17:03 ` Zhang Yi
2018-08-07 9:13 ` Jan Kara
2018-07-10 17:04 ` [PATCH V2 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-07-13 14:29 ` [PATCH V2 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang,Yi
2018-07-20 14:11 ` Zhang,Yi
2018-07-20 8:32 ` Paolo Bonzini
2018-07-20 16:24 ` Zhang,Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a42f73-1772-24eb-26f0-efd892b0487c@linux.intel.com \
--to=yi.z.zhang@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yi.z.zhang@intel.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).