From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3642DC4CEC9 for ; Tue, 17 Sep 2019 08:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0868721881 for ; Tue, 17 Sep 2019 08:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389187AbfIQIs0 (ORCPT ); Tue, 17 Sep 2019 04:48:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:53548 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728698AbfIQIsZ (ORCPT ); Tue, 17 Sep 2019 04:48:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4B6B1AE37; Tue, 17 Sep 2019 08:48:20 +0000 (UTC) Subject: Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression To: Feng Tang Cc: Stephen Rothwell , Rong Chen , michel@daenzer.net, linux-kernel@vger.kernel.org, dri-devel , lkp@01.org References: <20190813093616.GA65475@shbuild999.sh.intel.com> <64d41701-55a4-e526-17ae-8936de4bc1ef@suse.de> <20190824051605.GA63850@shbuild999.sh.intel.com> <1b897bfe-fd40-3ae3-d867-424d1fc08c44@suse.de> <44029e80-ba00-8246-dec0-fda122d53f5e@suse.de> <90e78ce8-d46a-5154-c324-a05aa1743c98@intel.com> <2e1b4d65-d477-f571-845d-fa0a670859af@suse.de> <20190904062716.GC5541@shbuild999.sh.intel.com> <6806e973-4cf7-bcac-54b4-4fac21698ece@suse.de> <20190916090652.GK5541@shbuild999.sh.intel.com> From: Thomas Zimmermann Openpgp: preference=signencrypt Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNKFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmNvbT7CwJQEEwEIAD4W IQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznTtgIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRBoDcEdUwt6I7D7CACBK42XW+7mCiK8ioXMEy1NzGbXC51RzGea8N83oEJS 1KVUtQxrkDxgrW/WLSl/TfqHFsJpdEFOv1XubWbleun3uKPy0e5vZCd5UjZPkeNjnqfCYTDy hVVsdOuFbtWDppJyJrThLqr9AgSFmoCNNUt1SVpYEEOLNE6C32BhlnSq21VLC+YXTgO/ZHTa YXkq54hHj63jwrcjkBSCkXLh37kHeqnl++GHpN+3R+o3w2OpwHAlvVjdKPT27v1tVkiydsFG 65Vd0n3m/ft+IOrGgxQM1C20uqKvsZGB4r3OGR50ekAybO7sjEJJ1Obl4ge/6RRqcvKz4LMb tGs85D6tPIeFzsBNBFs50uABCADGJj+DP1fk+UWOWrf4O61HTbC4Vr9QD2K4fUUHnzg2B6zU R1BPXqLGG0+lzK8kfYU/F5RjmEcClsIkAaFkg4kzKP14tvY1J5+AV3yNqcdg018HNtiyrSwI E0Yz/qm1Ot2NMZ0DdvVBg22IMsiudQ1tx9CH9mtyTbIXgACvl3PW2o9CxiHPE/bohFhwZwh/ kXYYAE51lhinQ3oFEeQZA3w4OTvxSEspiQR8dg8qJJb+YOAc5IKk6sJmmM7JfFMWSr22satM 23oQ3WvJb4RV6HTRTAIEyyZS7g2DhiytgMG60t0qdABG5KXSQW+OKlZRpuWwKWaLh3if/p/u 69dvpanbABEBAAHCwHwEGAEIACYWIQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznS4AIbDAUJ A8JnAAAKCRBoDcEdUwt6I6X3CACJ8D+TpXBCqJE5xwog08+Dp8uBpx0T9n1wE0GQisZruACW NofYn8PTX9k4wmegDLwt7YQDdKxQ4+eTfZeLNQqWg6OCftH5Kx7sjWnJ09tOgniVdROzWJ7c VJ/i0okazncsJ+nq48UYvRGE1Swh3A4QRIyphWX4OADOBmTFl9ZYNPnh23eaC9WrNvFr7yP7 iGjMlfEW8l6Lda//EC5VpXVNza0xeae0zFNst2R9pn+bLkihwDLWxOIyifGRxTqNxoS4I1aw VhxPSVztPMSpIA/sOr/N/p6JrBLn+gui2K6mP7bGb8hF+szfArYqz3T1rv1VzUWAJf5Wre5U iNx9uqqx Message-ID: <60ae9ffa-88e0-1219-ee6a-269495055df2@suse.de> Date: Tue, 17 Sep 2019 10:48:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190916090652.GK5541@shbuild999.sh.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9ZZHJcQW1k4wQnURYJ0ql7z0sO8SEELPZ" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9ZZHJcQW1k4wQnURYJ0ql7z0sO8SEELPZ Content-Type: multipart/mixed; boundary="aIvj5zB7g10AQ8FjRxpBiw5DdT3NKsk9p"; protected-headers="v1" From: Thomas Zimmermann To: Feng Tang Cc: Stephen Rothwell , Rong Chen , michel@daenzer.net, linux-kernel@vger.kernel.org, dri-devel , lkp@01.org Message-ID: <60ae9ffa-88e0-1219-ee6a-269495055df2@suse.de> Subject: Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression References: <20190813093616.GA65475@shbuild999.sh.intel.com> <64d41701-55a4-e526-17ae-8936de4bc1ef@suse.de> <20190824051605.GA63850@shbuild999.sh.intel.com> <1b897bfe-fd40-3ae3-d867-424d1fc08c44@suse.de> <44029e80-ba00-8246-dec0-fda122d53f5e@suse.de> <90e78ce8-d46a-5154-c324-a05aa1743c98@intel.com> <2e1b4d65-d477-f571-845d-fa0a670859af@suse.de> <20190904062716.GC5541@shbuild999.sh.intel.com> <6806e973-4cf7-bcac-54b4-4fac21698ece@suse.de> <20190916090652.GK5541@shbuild999.sh.intel.com> In-Reply-To: <20190916090652.GK5541@shbuild999.sh.intel.com> --aIvj5zB7g10AQ8FjRxpBiw5DdT3NKsk9p Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 16.09.19 um 11:06 schrieb Feng Tang: > Hi Thomas, >=20 > On Mon, Sep 09, 2019 at 04:12:37PM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 04.09.19 um 08:27 schrieb Feng Tang: >>> Hi Thomas, >>> >>> On Wed, Aug 28, 2019 at 12:51:40PM +0200, Thomas Zimmermann wrote: >>>> Hi >>>> >>>> Am 28.08.19 um 11:37 schrieb Rong Chen: >>>>> Hi Thomas, >>>>> >>>>> On 8/28/19 1:16 AM, Thomas Zimmermann wrote: >>>>>> Hi >>>>>> >>>>>> Am 27.08.19 um 14:33 schrieb Chen, Rong A: >>>>>>> Both patches have little impact on the performance from our side.= >>>>>> Thanks for testing. Too bad they doesn't solve the issue. >>>>>> >>>>>> There's another patch attached. Could you please tests this as wel= l? >>>>>> Thanks a lot! >>>>>> >>>>>> The patch comes from Daniel Vetter after discussing the problem on= IRC. >>>>>> The idea of the patch is that the old mgag200 code might display m= uch >>>>>> less frames that the generic code, because mgag200 only prints fro= m >>>>>> non-atomic context. If we simulate this with the generic code, we = should >>>>>> see roughly the original performance. >>>>>> >>>>>> >>>>> >>>>> It's cool, the patch "usecansleep.patch" can fix the issue. >>>> >>>> Thank you for testing. But don't get too excited, because the patch >>>> simulates a bug that was present in the original mgag200 code. A >>>> significant number of frames are simply skipped. That is apparently = the >>>> reason why it's faster. >>> >>> Thanks for the detailed info, so the original code skips time-consumi= ng >>> work inside atomic context on purpose. Is there any space to optmise = it? >>> If 2 scheduled update worker are handled at almost same time, can one= be >>> skipped? >> >> We discussed ideas on IRC and decided that screen updates could be >> synchronized with vblank intervals. This may give some rate limiting t= o >> the output. >> >> If you like, you could try the patch set at [1]. It adds the respectiv= e >> code to console and mgag200. >=20 > I just tried the 2 patches, no obvious change (comparing to the > 18.8% regression), both in overall benchmark and micro-profiling. >=20 > 90f479ae51afa45e 04a0983095feaee022cdd65e3e4=20 > ---------------- ---------------------------=20 > 37236 =C2=B1 3% +2.5% 38167 =C2=B1 3% vm-scalability.= median > 0.15 =C2=B1 24% -25.1% 0.11 =C2=B1 23% vm-scalability.= median_stddev > 0.15 =C2=B1 23% -25.1% 0.11 =C2=B1 22% vm-scalability.= stddev > 12767318 =C2=B1 4% +2.5% 13089177 =C2=B1 3% vm-scalability.= throughput Thank you for testing. I wish we'd seen at least some improvement. Best regards Thomas > Thanks, > Feng >=20 >> >> Best regards >> Thomas >> >> [1] >> https://lists.freedesktop.org/archives/dri-devel/2019-September/234850= =2Ehtml >> >>> >>> Thanks, >>> Feng >>> >>>> >>>> Best regards >>>> Thomas >> >> --=20 >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany >> GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah >> HRB 21284 (AG N=C3=BCrnberg) >> >=20 >=20 >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --aIvj5zB7g10AQ8FjRxpBiw5DdT3NKsk9p-- --9ZZHJcQW1k4wQnURYJ0ql7z0sO8SEELPZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl2Anc4ACgkQaA3BHVML eiOSrggAtLPLrXGkvqqk+2xrXjtvmOh/0u351u7AcW2rCQCh/mICUG1TZYxauYm+ xenRvkRdsd48LzzlhjH/ERAwK2G56UE3dNLtqSwyHnls4eaBxjP4aGj3gQTvw7uN fOAxcNbRFmCnpWow4/cBXkL2w5tLo2cW7TwUdhbWxRAvieHe7wzTvR0THJsdWhmH WKSDoME8v5M28vu1qq2K31Tz3O0bmwBycEJtB7dusWETH2agGEAB0iX5vlC+UFqw 575/rpWIVOyR9LR+KcuSwgut1wVrbvpUtzSwt6rbiKp2biy574Xrir/0ZqNjalBy 3eqL4agl6kEH/NVhIScxIOBXakP0iw== =ymuu -----END PGP SIGNATURE----- --9ZZHJcQW1k4wQnURYJ0ql7z0sO8SEELPZ--