From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 460FDC43381 for ; Fri, 1 Mar 2019 06:52:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1518D2186A for ; Fri, 1 Mar 2019 06:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727535AbfCAGwe (ORCPT ); Fri, 1 Mar 2019 01:52:34 -0500 Received: from mga04.intel.com ([192.55.52.120]:48665 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbfCAGwe (ORCPT ); Fri, 1 Mar 2019 01:52:34 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2019 22:52:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,426,1544515200"; d="scan'208";a="303501791" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 28 Feb 2019 22:52:33 -0800 Received: from [10.251.86.205] (abudanko-mobl.ccr.corp.intel.com [10.251.86.205]) by linux.intel.com (Postfix) with ESMTP id EFFB358011C; Thu, 28 Feb 2019 22:52:30 -0800 (PST) Subject: Re: [PATCH v4 01/10] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines From: Alexey Budankov To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , Andi Kleen , linux-kernel References: <20190228184612.GF9508@kernel.org> <33eb224d-3974-ebaa-20b7-9dbb66711839@linux.intel.com> Organization: Intel Corp. Message-ID: <60b8c13f-75c8-8402-74ad-95f10ec631cd@linux.intel.com> Date: Fri, 1 Mar 2019 09:52:28 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <33eb224d-3974-ebaa-20b7-9dbb66711839@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.02.2019 23:11, Alexey Budankov wrote: > > On 28.02.2019 21:46, Arnaldo Carvalho de Melo wrote: >> Em Thu, Feb 28, 2019 at 11:59:01AM +0300, Alexey Budankov escreveu: >>> +++ b/tools/build/Makefile.feature >>> @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \ >>> sched_getcpu \ >>> sdt \ >>> setns \ >>> - libaio >>> + libaio \ >>> + libzstd >> >> Since you added this as a basic feature to test, add this when you >> resubmit, so that 'perf -vv' tells us that this basic feature is indeed >> present. > > Yes, will do. Actually came to similar idea when > observed your test report in pull requests: > > # perf version --build-options > perf version 5.0.rc5.gde667c > dwarf: [ on ] # HAVE_DWARF_SUPPORT > dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT > glibc: [ on ] # HAVE_GLIBC_SUPPORT > gtk2: [ on ] # HAVE_GTK2_SUPPORT > syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT > libbfd: [ on ] # HAVE_LIBBFD_SUPPORT > libelf: [ on ] # HAVE_LIBELF_SUPPORT > libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT > numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT > libperl: [ on ] # HAVE_LIBPERL_SUPPORT > libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT > libslang: [ on ] # HAVE_SLANG_SUPPORT > libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT > libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT > libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT > zlib: [ on ] # HAVE_ZLIB_SUPPORT > lzma: [ on ] # HAVE_LZMA_SUPPORT > get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT > bpf: [ on ] # HAVE_LIBBPF_SUPPORT > > and it misses HAVE_ZSTD_SUPPORT define. implemented this: tools/perf/perf -vv perf version 4.13.rc5.g20492c dwarf: [ on ] # HAVE_DWARF_SUPPORT dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT glibc: [ on ] # HAVE_GLIBC_SUPPORT gtk2: [ on ] # HAVE_GTK2_SUPPORT syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT libbfd: [ on ] # HAVE_LIBBFD_SUPPORT libelf: [ on ] # HAVE_LIBELF_SUPPORT libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT libperl: [ on ] # HAVE_LIBPERL_SUPPORT libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT libslang: [ on ] # HAVE_SLANG_SUPPORT libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT zlib: [ on ] # HAVE_ZLIB_SUPPORT lzma: [ on ] # HAVE_LZMA_SUPPORT get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT bpf: [ on ] # HAVE_LIBBPF_SUPPORT aio: [ on ] # HAVE_AIO_SUPPORT <= zstd: [ on ] # HAVE_ZSTD_SUPPORT <= ~Alexey > > Thanks, > Alexey > >> >> >> diff --git a/tools/perf/builtin-version.c b/tools/perf/builtin-version.c >> index 50df168be326..d41197fc8cef 100644 >> --- a/tools/perf/builtin-version.c >> +++ b/tools/perf/builtin-version.c >> @@ -78,6 +78,7 @@ static void library_status(void) >> STATUS(HAVE_LZMA_SUPPORT, lzma); >> STATUS(HAVE_AUXTRACE_SUPPORT, get_cpuid); >> STATUS(HAVE_LIBBPF_SUPPORT, bpf); >> + STATUS(HAVE_ZSTD_SUPPORT, bpf); >> } >> >> int cmd_version(int argc, const char **argv) >> >