linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Wesley Cheng <wcheng@codeaurora.org>,
	heikki.krogerus@linux.intel.com, mark.rutland@arm.com,
	broonie@kernel.org, bjorn.andersson@linaro.org,
	gregkh@linuxfoundation.org, lgirdwood@gmail.com,
	agross@kernel.org, robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	jackp@codeaurora.org, bryan.odonoghue@linaro.org,
	lijun.kernel@gmail.com
Subject: Re: [PATCH v3 4/6] regulator: Add support for QCOM PMIC VBUS booster
Date: Wed, 17 Jun 2020 11:23:57 -0700	[thread overview]
Message-ID: <60c0f7c9-f986-bf54-6112-1c71a317ae5b@infradead.org> (raw)
In-Reply-To: <20200617180209.5636-5-wcheng@codeaurora.org>

Hi--

On 6/17/20 11:02 AM, Wesley Cheng wrote:
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 074a2ef55943..79d6b7596f0b 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -797,6 +797,16 @@ config REGULATOR_QCOM_SPMI
>  	  Qualcomm SPMI PMICs as a module. The module will be named
>  	  "qcom_spmi-regulator".
>  
> +config REGULATOR_QCOM_USB_VBUS
> +	tristate "Qualcomm USB Vbus regulator driver"
> +	depends on SPMI || COMPILE_TEST
> +	help
> +	  If you say yes to this option, support will be included for the
> +	  regulator used to enable the VBUS output.
> +
> +	  Say M here if you want to include support for enabling the VBUS output
> +	  as a module. The module will be named "qcom_usb_vbus-regulator".

Since '-' in a module name is converted to '_' when the module is loaded, it
probably makes more sense to tell the user that the module name will be
qcom_usb_vbus_regulator.

> +
>  config REGULATOR_RC5T583
>  	tristate "RICOH RC5T583 Power regulators"
>  	depends on MFD_RC5T583
> diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
> index c0d6b96ebd78..cbab28aa7b56 100644
> --- a/drivers/regulator/Makefile
> +++ b/drivers/regulator/Makefile
> @@ -89,6 +89,7 @@ obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o
>  obj-$(CONFIG_REGULATOR_QCOM_RPMH) += qcom-rpmh-regulator.o
>  obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.o
>  obj-$(CONFIG_REGULATOR_QCOM_SPMI) += qcom_spmi-regulator.o
> +obj-$(CONFIG_REGULATOR_QCOM_USB_VBUS) += qcom_usb_vbus-regulator.o
>  obj-$(CONFIG_REGULATOR_PALMAS) += palmas-regulator.o
>  obj-$(CONFIG_REGULATOR_PFUZE100) += pfuze100-regulator.o
>  obj-$(CONFIG_REGULATOR_PV88060) += pv88060-regulator.o

thanks.
-- 
~Randy


  reply	other threads:[~2020-06-17 18:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 18:02 [PATCH v3 0/6] Introduce PMIC based USB type C detection Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 1/6] usb: typec: Add QCOM PMIC typec detection driver Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding Wesley Cheng
2020-06-18 18:33   ` Rob Herring
2020-06-18 20:09     ` Wesley Cheng
2020-06-18 22:23       ` Rob Herring
2020-06-22 17:47         ` Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 3/6] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block Wesley Cheng
2020-06-21  7:09   ` Bjorn Andersson
2020-06-17 18:02 ` [PATCH v3 4/6] regulator: Add support for QCOM PMIC VBUS booster Wesley Cheng
2020-06-17 18:23   ` Randy Dunlap [this message]
2020-06-21  7:04   ` Bjorn Andersson
2020-06-17 18:02 ` [PATCH v3 5/6] dt-bindings: regulator: Add dt-binding for QCOM PMIC VBUS output regulator Wesley Cheng
2020-06-17 18:02 ` [PATCH v3 6/6] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Wesley Cheng
2020-06-17 18:41   ` Jack Pham
2020-06-21  7:07   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60c0f7c9-f986-bf54-6112-1c71a317ae5b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jackp@codeaurora.org \
    --cc=lgirdwood@gmail.com \
    --cc=lijun.kernel@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wcheng@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).