Re: [PATCH v3] soc/tegra: Add devm_tegra_core_dev_init_opp_table()

From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Nicolas Chauvet <kwizart@gmail.com>,
	Viresh Kumar <vireshk@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
	Matt Merhar <mattmerhar@protonmail.com>,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org, Yangtao Li <tiny.windzz@gmail.com>
Subject: Re: [PATCH v3] soc/tegra: Add devm_tegra_core_dev_init_opp_table()
Date: Fri, 22 Jan 2021 17:41:05 +0300	[thread overview]
Message-ID: <60cfafdf-4615-5a41-103d-96c35ba1fa8c@gmail.com> (raw)
In-Reply-To: <20210122063537.7yd7ww47gl2rdsdu@vireshk-i7>

22.01.2021 09:35, Viresh Kumar пишет:
> On 21-01-21, 22:01, Dmitry Osipenko wrote:
>> Add common helper which initializes OPP table for Tegra SoC core devices.
>>
>> Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
>> Tested-by: Dmitry Osipenko <digetx@gmail.com> # A500 T20 and Nexus7 T30
>> Tested-by: Nicolas Chauvet <kwizart@gmail.com> # PAZ00 T20 and TK1 T124
>> Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
>> [tested on some other non-upstreamed-yet T20/30/114 devices as well]
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>
>> Changelog:
>>
>> v3: - This patch is factored out from [1] to ease merging of the patches
>>       that will use the new helper. The goal is to get this new helper
>>       into 5.12, this should remove dependency on this patch for a several
>>       patchsets of a different subsystems (DRM, media, memory, etc) that
>>       will target 5.13.
>>
>>       @Thierry/Jon, please review and apply this patch for 5.12!
> 
> This is not how stuff works in kernel Dmitry, every commit in the
> kernel tree should build(at least)/boot fine. Your patch can only be
> applied once your base tree has all the patches on which your work is
> based of, otherwise this will lead to build failure (stuff like git
> bisect breaks with that). It would be better if you take this patch in
> 5.13, or after 5.12-rc2 once all other stuff lands.
> 

OMG, I completely missed that the devm series from Yangtao Li isn't
merged yet.

Viresh / Yangtao, will be it be okay if I'll collect all the
prerequisite devm patches from Yangtao + add this patch into a single
series that could be merged via the OPP tree for 5.12?

Of course Thierry or Jon will need to give the ack for the Tegra changes
in that case.