From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] ring-buffer: remove leading spaces before tabs
Date: Wed, 9 Jun 2021 11:06:22 +0800 [thread overview]
Message-ID: <60fcce9f-abf5-4dd0-1bba-a1f19ec251d0@huawei.com> (raw)
In-Reply-To: <20210608105943.2376328c@oasis.local.home>
On 2021/6/8 22:59, Steven Rostedt wrote:
> On Tue, 8 Jun 2021 16:10:51 +0800
> Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
>> 1) Run the following command to find and remove the leading spaces before
>> tabs:
>> find kernel/trace/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/'
>> 2) Manually check and correct if necessary
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Sorry, but I do not accept whitespace changes. Clean ups like this is
> only welcomed if they come along with actual changes to the code around
It's the wrong way of thinking. It's like having mosquitoes in the house and
killing a mosquito only when you meet it. Mosquitoes will exist for a long
time, and not all mosquitoes will be killed. People who have been in the house
will always face being bitten unless they don't care.
> them. Otherwise, this just causes extra churn and unwelcomed work for
> the maintainer.
Yes, the changes are a little less. There is no owner for the whole kernel
module. So I had to take it apart. As a programmer, since I discovered it,
I had an instinctive drive to fix it. Even if it won't be accepted.
>
> -- Steve
>
>
>> ---
>> kernel/trace/ring_buffer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
>> index 833ade3d0b00..a555258556c5 100644
>> --- a/kernel/trace/ring_buffer.c
>> +++ b/kernel/trace/ring_buffer.c
>> @@ -5887,7 +5887,7 @@ static __init int test_ringbuffer(void)
>> }
>>
>> kthread_bind(rb_threads[cpu], cpu);
>> - wake_up_process(rb_threads[cpu]);
>> + wake_up_process(rb_threads[cpu]);
>> }
>>
>> /* Now create the rb hammer! */
>
>
> .
>
prev parent reply other threads:[~2021-06-09 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 8:10 [PATCH 1/1] ring-buffer: remove leading spaces before tabs Zhen Lei
2021-06-08 14:59 ` Steven Rostedt
2021-06-09 3:06 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60fcce9f-abf5-4dd0-1bba-a1f19ec251d0@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).