linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Alan Stern <stern@rowland.harvard.edu>, Andrea Vai <andrea.vai@unipv.it>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	USB list <linux-usb@vger.kernel.org>,
	SCSI development list <linux-scsi@vger.kernel.org>,
	Himanshu Madhani <himanshu.madhani@cavium.com>,
	Hannes Reinecke <hare@suse.com>, Ming Lei <ming.lei@redhat.com>,
	Omar Sandoval <osandov@fb.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Hans Holmberg <Hans.Holmberg@wdc.com>,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6
Date: Tue, 5 Nov 2019 16:29:18 -0700	[thread overview]
Message-ID: <61033407-731e-8cf5-8590-b07e2567693a@kernel.dk> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1911051326040.1678-100000@iolanthe.rowland.org>

On 11/5/19 11:31 AM, Alan Stern wrote:
> On Tue, 5 Nov 2019, Andrea Vai wrote:
> 
>> Il giorno lun, 04/11/2019 alle 13.20 -0500, Alan Stern ha scritto:
> 
>>> You should be able to do something like this:
>>>
>>>          cd linux
>>>          patch -p1 </path/to/patch2
>>>
>>> and that should work with no errors.  You don't need to use git to
>>> apply a patch.
>>>
>>> In case that patch2 file was mangled somewhere along the way, I
>>> have
>>> attached a copy to this message.
>>
>> Ok, so the "patch" command worked, the kernel compiled and ran, but
>> the test still failed (273, 108, 104, 260, 177, 236, 179, 1123, 289,
>> 873 seconds to copy a 500MB file, vs. ~30 seconds with the "good"
>> kernel).
>>
>> Let me know what else could I do,
> 
> I'm out of suggestions.  If anyone else knows how to make a kernel with
> no legacy queuing support -- only multiqueue -- issue I/O requests
> sequentially, please speak up.

Do we know for a fact that the device needs strictly serialized requests
to not stall? And writes in particular? I won't comment on how broken
that is, just trying to establish this as the problem that's making this
particular device be slow?

I've lost track of this thread, but has mq-deadline been tried as the
IO scheduler? We do have support for strictly serialized (writes)
since that's required for zoned device, wouldn't be hard at all to make
this cover a blacklisted device like this one.

> In the absence of any responses, after a week or so I will submit a
> patch to revert the f664a3cc17b7 ("scsi: kill off the legacy IO path")
> commit.

That's not going to be feasible.

-- 
Jens Axboe


  reply	other threads:[~2019-11-05 23:29 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0cd6ac36b7ab644576fc0f3f5bd4a880c33855d1.camel@unipv.it>
2019-11-05 18:31 ` Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6 Alan Stern
2019-11-05 23:29   ` Jens Axboe [this message]
2019-11-06 16:03     ` Alan Stern
2019-11-06 22:13       ` Damien Le Moal
2019-11-07  7:04         ` Andrea Vai
2019-11-07  7:54           ` Damien Le Moal
2019-11-07 18:59             ` Andrea Vai
2019-11-08  8:42               ` Damien Le Moal
2019-11-08 14:33                 ` Jens Axboe
2019-11-11 10:46                   ` Andrea Vai
2019-11-09 10:09                 ` Ming Lei
2019-11-09 22:28               ` Ming Lei
2019-11-11 10:50                 ` Andrea Vai
2019-11-11 11:05                   ` Ming Lei
2019-11-11 11:13                     ` Andrea Vai
2019-11-22 19:16                 ` Andrea Vai
2019-11-23  7:28                   ` Ming Lei
2019-11-23 15:44                     ` Andrea Vai
2019-11-25  3:54                       ` Ming Lei
2019-11-25 10:11                         ` Andrea Vai
2019-11-25 10:29                           ` Ming Lei
2019-11-25 14:58                             ` Andrea Vai
2019-11-25 15:15                               ` Ming Lei
2019-11-25 18:51                                 ` Andrea Vai
2019-11-26  2:32                                   ` Ming Lei
2019-11-26  7:46                                     ` Andrea Vai
2019-11-26  9:15                                       ` Ming Lei
2019-11-26 10:24                                         ` Ming Lei
2019-11-26 11:14                                         ` Andrea Vai
2019-11-27  2:05                                           ` Ming Lei
2019-11-27  9:39                                             ` Andrea Vai
2019-11-27 13:08                                               ` Ming Lei
2019-11-27 15:01                                                 ` Andrea Vai
2019-11-27  0:21                                       ` Finn Thain
2019-11-27  8:14                                         ` AW: " Schmid, Carsten
2019-11-27 21:49                                           ` Finn Thain
2019-11-28  7:46                                           ` Andrea Vai
2019-11-28  8:12                                             ` AW: " Schmid, Carsten
2019-11-28 11:40                                               ` Andrea Vai
2019-11-28 17:39                                               ` Alan Stern
2019-11-28  9:17                                             ` Ming Lei
2019-11-28 17:34                                               ` Andrea Vai
2019-11-29  0:57                                                 ` Ming Lei
2019-11-29  2:35                                                   ` Ming Lei
2019-11-29 14:41                                                     ` Andrea Vai
2019-12-03  2:23                                                       ` Ming Lei
2019-12-10  7:35                                                         ` Andrea Vai
2019-12-10  8:05                                                           ` Ming Lei
2019-12-11  2:41                                                             ` Theodore Y. Ts'o
2019-12-11  4:00                                                               ` Ming Lei
2019-12-11 16:07                                                                 ` Theodore Y. Ts'o
2019-12-11 21:33                                                                   ` Ming Lei
2019-12-12  7:34                                                                     ` Andrea Vai
2019-12-18  8:25                                                                     ` Andrea Vai
2019-12-18  9:48                                                                       ` Ming Lei
     [not found]                                                                         ` <b1b6a0e9d690ecd9432025acd2db4ac09f834040.camel@unipv.it>
2019-12-23 13:08                                                                           ` Ming Lei
2019-12-23 14:02                                                                             ` Andrea Vai
2019-12-24  1:32                                                                               ` Ming Lei
2019-12-24  8:04                                                                                 ` Andrea Vai
2019-12-24  8:47                                                                                   ` Ming Lei
2019-12-23 16:26                                                                             ` Theodore Y. Ts'o
2019-12-23 16:29                                                                               ` Andrea Vai
2019-12-23 17:22                                                                                 ` Theodore Y. Ts'o
2019-12-23 18:45                                                                                   ` Andrea Vai
2019-12-23 19:53                                                                                     ` Theodore Y. Ts'o
2019-12-24  1:27                                                                                       ` Ming Lei
2019-12-24  6:49                                                                                         ` Andrea Vai
2019-12-24  8:51                                                                                         ` Andrea Vai
2019-12-24  9:35                                                                                           ` Ming Lei
2019-12-25  5:17                                                                                         ` Theodore Y. Ts'o
2019-12-26  2:27                                                                                           ` Ming Lei
2019-12-26  3:30                                                                                             ` Theodore Y. Ts'o
2019-12-26  8:37                                                                                               ` Ming Lei
2020-01-07  7:51                                                                                                 ` Andrea Vai
     [not found]                                                                                               ` <20200101074310.10904-1-hdanton@sina.com>
2020-01-01 13:53                                                                                                 ` slow IO on USB media Ming Lei
2019-11-29 11:44                                                   ` AW: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6 Bernd Schubert
2019-12-02  7:01                                                     ` Andrea Vai
2019-11-28 17:10                                         ` Andrea Vai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61033407-731e-8cf5-8590-b07e2567693a@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Damien.LeMoal@wdc.com \
    --cc=Hans.Holmberg@wdc.com \
    --cc=andrea.vai@unipv.it \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.com \
    --cc=himanshu.madhani@cavium.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=osandov@fb.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).