From: Marcello Sylvester Bauer <sylv@sylv.io>
To: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Marcello Sylvester Bauer <sylv@sylv.io>,
linux-doc@vger.kernel.org
Subject: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280
Date: Thu, 17 Feb 2022 15:41:34 +0100 [thread overview]
Message-ID: <6103836f1116a045a25919ae3e5c18dfdc485902.1645108566.git.sylv@sylv.io> (raw)
In-Reply-To: <cover.1645108566.git.sylv@sylv.io>
Add support for another family of Infineon Multi-phase controllers.
The xdpe11280 uses linear instead of vid data format for VOUT.
Add the required logic to detect VOUT_MODE during identification,
and set the format accordingly.
Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
---
Documentation/hwmon/xdpe12284.rst | 10 +++++++---
drivers/hwmon/pmbus/xdpe12284.c | 17 ++++++++++++++++-
2 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/Documentation/hwmon/xdpe12284.rst b/Documentation/hwmon/xdpe12284.rst
index 67d1f87808e5..e9a5a19b0c3d 100644
--- a/Documentation/hwmon/xdpe12284.rst
+++ b/Documentation/hwmon/xdpe12284.rst
@@ -5,6 +5,10 @@ Kernel driver xdpe122
Supported chips:
+ * Infineon XDPE11280
+
+ Prefix: 'xdpe11280'
+
* Infineon XDPE12254
Prefix: 'xdpe12254'
@@ -20,9 +24,9 @@ Authors:
Description
-----------
-This driver implements support for Infineon Multi-phase XDPE122 family
-dual loop voltage regulators.
-The family includes XDPE12284 and XDPE12254 devices.
+This driver implements support for Infineon Multi-phase XDPE112 and XDPE122
+family dual loop voltage regulators.
+These families include XDPE11280, XDPE12284 and XDPE12254 devices.
The devices from this family complaint with:
- Intel VR13 and VR13HC rev 1.3, IMVP8 rev 1.2 and IMPVP9 rev 1.3 DC-DC
diff --git a/drivers/hwmon/pmbus/xdpe12284.c b/drivers/hwmon/pmbus/xdpe12284.c
index b07da06a40c9..ec947c697670 100644
--- a/drivers/hwmon/pmbus/xdpe12284.c
+++ b/drivers/hwmon/pmbus/xdpe12284.c
@@ -27,6 +27,9 @@ static int xdpe122_read_word_data(struct i2c_client *client, int page,
s32 mantissa;
int ret;
+ if (info->format[PSC_VOLTAGE_OUT] == linear)
+ return -ENODATA;
+
switch (reg) {
case PMBUS_VOUT_OV_FAULT_LIMIT:
case PMBUS_VOUT_UV_FAULT_LIMIT:
@@ -75,9 +78,19 @@ static int xdpe122_read_word_data(struct i2c_client *client, int page,
static int xdpe122_identify(struct i2c_client *client,
struct pmbus_driver_info *info)
{
- u8 vout_params;
+ u8 vout_mode, vout_params;
int i, ret;
+ ret = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);
+ if (ret < 0)
+ return ret;
+
+ vout_mode = ret >> 5;
+ if (vout_mode == 0) {
+ info->format[PSC_VOLTAGE_OUT] = linear;
+ return 0;
+ }
+
for (i = 0; i < XDPE122_PAGE_NUM; i++) {
/* Read the register with VOUT scaling value.*/
ret = pmbus_read_byte_data(client, i, PMBUS_VOUT_MODE);
@@ -140,6 +153,7 @@ static int xdpe122_probe(struct i2c_client *client)
}
static const struct i2c_device_id xdpe122_id[] = {
+ {"xdpe11280", 0},
{"xdpe12254", 0},
{"xdpe12284", 0},
{}
@@ -148,6 +162,7 @@ static const struct i2c_device_id xdpe122_id[] = {
MODULE_DEVICE_TABLE(i2c, xdpe122_id);
static const struct of_device_id __maybe_unused xdpe122_of_match[] = {
+ {.compatible = "infineon,xdpe11280"},
{.compatible = "infineon,xdpe12254"},
{.compatible = "infineon,xdpe12284"},
{}
--
2.34.1
next prev parent reply other threads:[~2022-02-17 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:41 [PATCH v2 0/3] Support XDPE112 Marcello Sylvester Bauer
2022-02-17 14:41 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Add xdpe11280 Marcello Sylvester Bauer
2022-02-24 22:12 ` Rob Herring
2022-02-17 14:41 ` Marcello Sylvester Bauer [this message]
2022-02-17 15:20 ` [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280 Guenter Roeck
2022-02-17 16:39 ` sylv
2022-02-17 18:11 ` Guenter Roeck
2022-02-17 18:38 ` sylv
2022-02-17 19:25 ` Guenter Roeck
2022-02-21 12:13 ` sylv
2022-02-25 16:39 ` Guenter Roeck
2022-02-26 15:32 ` Marcello Sylvester Bauer
2022-02-17 14:41 ` [PATCH v2 3/3] hwmon (xdpe12284): Add regulator support Marcello Sylvester Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6103836f1116a045a25919ae3e5c18dfdc485902.1645108566.git.sylv@sylv.io \
--to=sylv@sylv.io \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).