From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006BFC43461 for ; Sat, 5 Sep 2020 18:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B429A2074D for ; Sat, 5 Sep 2020 18:57:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B1RmBQpd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728642AbgIES5R (ORCPT ); Sat, 5 Sep 2020 14:57:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728397AbgIES5N (ORCPT ); Sat, 5 Sep 2020 14:57:13 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EE3EC061244; Sat, 5 Sep 2020 11:57:12 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id b12so5537096lfp.9; Sat, 05 Sep 2020 11:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JFaZX1yPOD5YrQmNNicSv1U0vDJOVK3tkWFEsyFX4y4=; b=B1RmBQpdyLlyQgJYVUrPN9Cvl8GQ++LbY4Lt3/r+6FNcLlrHHi3xyKUU1hvbb49LE0 BJzRGQkIs2RhGGcCcu6TopgxIhQBi47AN2TmI0fy9Uk8Ua07PkPE2HWrdCGdPXAhaLoG VR9VnG3UNvHjD8wP+wQVG5IRplNurGSyNUlo0XvgyoirnVoYDnDNnyaDqf7V8JR37wVq nDc9wddtckAigqQC96qxoAaMXiwCfNe5F+MfiJacds0S9DSkwWNsq5MUDYMH1WjnOFsn pY2uvrdUOXMVhBf4sUZwUjC1KIFkeL9z5wY0idygzWZJbZ5sNAr5Wu6bfIW2Y7BBI8Gm Vn6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JFaZX1yPOD5YrQmNNicSv1U0vDJOVK3tkWFEsyFX4y4=; b=qqKf44pRn3yvBdTNT/UrKnreaWQctPGUSuVsstGA1CJ3+88SkyBAA6u7dKApE7Vrf3 i44IQzXWvQQie9RBJ0heMzBArPVl8rtdsdzZmIkPg6YZaNH6g+o4yl7K4xsR2ANWnmeZ l1DrndKIBp5a8aNwVORRGXDdIRgacrbqnySQEZwIHR03kU5z7cDDHBsyICi0qfTlStpZ nnOoWaxZTBwt8aJ5PAyJW0Gyp8NOUKTigu1Gvox95IO62oulOcaY4o6r5KoI8f/HnQ5M qsDZgMpRzrGIFw8MsiKiQhF/Uk86ed1kR5dcHd9+iTQr91k/X6Kgq6B16u7acIAVEKBJ YWpQ== X-Gm-Message-State: AOAM53102AFyn+Hka1WlQHj2tCzajDoLNBSAJg24/EuFq+HIidnLqrjU 0QY4LvifXxpEskozhTluCo0= X-Google-Smtp-Source: ABdhPJxhBO9puaUXmB4DBnS0NwVqnuYWcXfGNDEU/UyZMtvQEza5s0m079mZOr7saQ6QL9Ja8TMTzA== X-Received: by 2002:ac2:5547:: with SMTP id l7mr6639332lfk.153.1599332230136; Sat, 05 Sep 2020 11:57:10 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id q7sm2742041lfr.16.2020.09.05.11.57.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Sep 2020 11:57:09 -0700 (PDT) Subject: Re: [PATCH v2 1/1] Input: atmel_mxt_ts - implement I2C retries To: Andy Shevchenko , Jiada Wang Cc: "nick@shmanahar.org" , "dmitry.torokhov@gmail.com" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Andrew_Gabbasov@mentor.com" , "erosca@de.adit-jv.com" References: <20200903155904.17454-1-jiada_wang@mentor.com> From: Dmitry Osipenko Message-ID: <610b2513-7d62-386d-ed2a-54e1bea4df43@gmail.com> Date: Sat, 5 Sep 2020 21:57:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 05.09.2020 21:02, Andy Shevchenko пишет: ... >  #define MXT_CRC_TIMEOUT                1000    /* msec */ >  #define MXT_FW_RESET_TIME      3000    /* msec */ >  #define MXT_FW_CHG_TIMEOUT     300     /* msec */ > +#define MXT_WAKEUP_TIME                25      /* msec */ > > > Can we simple add _MS unit suffix to the definition? I'd expect this >  /* Command to unlock bootloader */ >  #define MXT_UNLOCK_CMD_MSB     0xaa > @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client, >         struct i2c_msg xfer[2]; >         u8 buf[2]; >         int ret; > +       bool retry = false; > > > Keep this ordered by length. and this to be separate patches that are cleaning whole driver code, otherwise there are no much benefits.