From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Andrey Konovalov <andreyknvl@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v13 4/7] arm64: mte: Enable TCO in functions that can read beyond buffer limits
Date: Tue, 23 Feb 2021 10:56:46 +0000 [thread overview]
Message-ID: <6111633c-3bbd-edfa-86a0-be580a9ebcc8@arm.com> (raw)
In-Reply-To: <20210222175825.GE19604@arm.com>
On 2/22/21 5:58 PM, Catalin Marinas wrote:
> That's because cpu_hotplug_lock is not a spinlock but a semaphore which
> implies sleeping. I don't think avoiding taking this semaphore
> altogether (as in the *_cpuslocked functions) is the correct workaround.
>
Thinking at it a second time I agree, it is not a good idea avoiding to take the
semaphore in this case.
> The mte_enable_kernel_async() function is called on each secondary CPU
> but we don't really need to attempt to toggle the static key on each of
> them as they all have the same configuration. Maybe do something like:
>
> if (!static_branch_unlikely(&mte_async_mode)))
> static_branch_enable(&mte_async_mode);
>
> so that it's only set on the boot CPU.
>
This should work, maybe with a comment that if we plan to introduce runtime
switching in between async and sync in future we need to revisit our strategy.
> The alternative is to use a per-CPU mask/variable instead of static
> branches but it's probably too expensive for those functions that were
> meant to improve performance.
>
I would not go for this approach because the reason why we introduced static
branches instead of having a normal variable saving the state was performances.
> We'll still have an issue with dynamically switching the async/sync mode
> at run-time. Luckily kasan doesn't do this now. The problem is that
> until the last CPU have been switched from async to sync, we can't
> toggle the static label. When switching from sync to async, we need
> to do it on the first CPU being switched.
>
I totally agree on this point. In the case of runtime switching we might need
the rethink completely the strategy and depends a lot on what we want to allow
and what not. For the kernel I imagine we will need to expose something in sysfs
that affects all the cores and then maybe stop_machine() to propagate it to all
the cores. Do you think having some of the cores running in sync mode and some
in async is a viable solution?
Probably it is worth to discuss it further once we cross that bridge.
> So, I think currently we can set the mte_async_mode label to true in
> mte_enable_kernel_async(), with the 'if' check above. For
> mte_enable_kernel_sync(), don't bother with setting the key to false but
> place a WARN_ONCE if the mte_async_mode is true. We can revisit it if
> kasan ever gains this run-time switch mode.
Indeed, this should work for now.
--
Regards,
Vincenzo
next prev parent reply other threads:[~2021-02-23 10:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 15:33 [PATCH v13 0/7] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino
2021-02-11 15:33 ` [PATCH v13 1/7] arm64: mte: Add asynchronous " Vincenzo Frascino
2021-02-12 21:21 ` Andrey Konovalov
2021-02-22 11:14 ` Vincenzo Frascino
2021-02-11 15:33 ` [PATCH v13 2/7] kasan: Add KASAN mode kernel parameter Vincenzo Frascino
2021-02-11 17:50 ` Andrey Konovalov
2021-02-12 11:26 ` Vincenzo Frascino
2021-02-11 15:33 ` [PATCH v13 3/7] kasan: Add report for async mode Vincenzo Frascino
2021-02-11 20:03 ` kernel test robot
2021-02-11 20:13 ` Andrey Konovalov
2021-02-12 11:25 ` Vincenzo Frascino
2021-02-12 14:47 ` Andrey Konovalov
2021-02-11 23:03 ` kernel test robot
2021-02-11 15:33 ` [PATCH v13 4/7] arm64: mte: Enable TCO in functions that can read beyond buffer limits Vincenzo Frascino
2021-02-12 17:21 ` Catalin Marinas
2021-02-22 12:08 ` Vincenzo Frascino
2021-02-22 17:58 ` Catalin Marinas
2021-02-23 10:56 ` Vincenzo Frascino [this message]
2021-02-23 12:05 ` Catalin Marinas
2021-02-23 12:22 ` Vincenzo Frascino
2021-02-23 12:49 ` Will Deacon
2021-02-23 13:14 ` Catalin Marinas
2021-02-23 14:25 ` Vincenzo Frascino
2021-02-11 15:33 ` [PATCH v13 5/7] arm64: mte: Enable async tag check fault Vincenzo Frascino
2021-02-11 15:33 ` [PATCH v13 6/7] arm64: mte: Report async tag faults before suspend Vincenzo Frascino
2021-02-12 12:00 ` Lorenzo Pieralisi
2021-02-12 12:30 ` Lorenzo Pieralisi
2021-02-12 13:05 ` Vincenzo Frascino
2021-02-12 13:19 ` Catalin Marinas
2021-02-12 17:24 ` Catalin Marinas
2021-02-11 15:33 ` [PATCH v13 7/7] kasan: don't run tests in async mode Vincenzo Frascino
2021-02-12 0:49 ` kernel test robot
2021-02-12 17:22 ` Catalin Marinas
2021-02-12 21:44 ` Andrey Konovalov
2021-02-22 11:17 ` Vincenzo Frascino
2021-02-22 13:35 ` Andrey Konovalov
2021-02-11 15:45 ` [PATCH v13 0/7] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6111633c-3bbd-edfa-86a0-be580a9ebcc8@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).