From: Randy Dunlap <rdunlap@infradead.org>
To: Roy Im <roy.im.opensource@diasemi.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Support Opensource <support.opensource@diasemi.com>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 3/3] Input: new da7280 haptic driver
Date: Thu, 23 Aug 2018 08:28:24 -0700 [thread overview]
Message-ID: <6115d6ca-8df6-1830-3c61-681610d8f2b0@infradead.org> (raw)
In-Reply-To: <2c28a93093c075e0145b70e7bc999f2654d0431d.1534830272.git.Roy.Im@diasemi.com>
On 08/20/2018 10:44 PM, Roy Im wrote:
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index ca59a2b..6e0de69 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -851,4 +851,16 @@ config INPUT_SC27XX_VIBRA
> To compile this driver as a module, choose M here. The module will
> be called sc27xx_vibra.
>
Hi,
Can you explain the "depends on" below, please.
> +config INPUT_DA7280_HAPTICS
> + tristate "Dialog Semiconductor DA7280 haptics support"
> + depends on (INPUT && I2C && SYSFS) || PWM
> + select INPUT_FF_MEMLESS
> + select REGMAP_I2C
If INPUT is disabled, and I2C is disabled, and SYSFS is disabled, but PWM=y,
then the "select"s will have problems with unmet dependencies.
> + help
> + Say Y to enable support for the haptics controller on
> + Dialog DA7280 chip.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called da7280-haptic.
That module name doesn't match what's in the Makefile (below).
> +
> endif
> diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
> index 9d0f9d1..d941348 100644
> --- a/drivers/input/misc/Makefile
> +++ b/drivers/input/misc/Makefile
> @@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000) += cma3000_d0x.o
> obj-$(CONFIG_INPUT_CMA3000_I2C) += cma3000_d0x_i2c.o
> obj-$(CONFIG_INPUT_COBALT_BTNS) += cobalt_btns.o
> obj-$(CONFIG_INPUT_CPCAP_PWRBUTTON) += cpcap-pwrbutton.o
> +obj-$(CONFIG_INPUT_DA7280_HAPTICS) += da7280.o
> obj-$(CONFIG_INPUT_DA9052_ONKEY) += da9052_onkey.o
> obj-$(CONFIG_INPUT_DA9055_ONKEY) += da9055_onkey.o
> obj-$(CONFIG_INPUT_DA9063_ONKEY) += da9063_onkey.o
--
~Randy
next prev parent reply other threads:[~2018-08-23 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 5:44 [PATCH V4 0/3] da7280: haptic driver submission Roy Im
2018-08-21 5:44 ` [PATCH V4 1/3] MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms Roy Im
2018-08-21 5:44 ` [PATCH V4 2/3] dt-bindings: input: Add document bindings for DA7280 Roy Im
2018-08-26 6:51 ` Pavel Machek
2018-08-27 5:02 ` Roy Im
2018-08-21 5:44 ` [PATCH V4 3/3] Input: new da7280 haptic driver Roy Im
2018-08-23 15:28 ` Randy Dunlap [this message]
2018-08-24 5:35 ` Roy Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6115d6ca-8df6-1830-3c61-681610d8f2b0@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=roy.im.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).