From: Hans Verkuil <hverkuil@xs4all.nl>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu
Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: platform: s3c-camif: Fix runtime PM imbalance in s3c_camif_open
Date: Thu, 17 Sep 2020 13:26:46 +0200 [thread overview]
Message-ID: <611ffe6a-c4ef-d23c-4d3f-a7771ce56bab@xs4all.nl> (raw)
In-Reply-To: <20200522082915.4731-1-dinghao.liu@zju.edu.cn>
On 22/05/2020 10:29, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
>
> Also, call pm_runtime_put() and v4l2_fh_release() when sensor_set_power()
> returns an error code.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/media/platform/s3c-camif/camif-capture.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c
> index 9ca49af29542..d42d9cfaf674 100644
> --- a/drivers/media/platform/s3c-camif/camif-capture.c
> +++ b/drivers/media/platform/s3c-camif/camif-capture.c
> @@ -552,11 +552,9 @@ static int s3c_camif_open(struct file *file)
> goto err_pm;
>
> ret = sensor_set_power(camif, 1);
> - if (!ret)
> - goto unlock;
This is wrong, now this will call v4l2_fh_release() as well on success.
This needs to be reworked.
Regards,
Hans
>
> - pm_runtime_put(camif->dev);
> err_pm:
> + pm_runtime_put(camif->dev);
> v4l2_fh_release(file);
> unlock:
> mutex_unlock(&camif->lock);
>
prev parent reply other threads:[~2020-09-17 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 8:29 [PATCH] media: platform: s3c-camif: Fix runtime PM imbalance in s3c_camif_open Dinghao Liu
2020-09-17 11:26 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=611ffe6a-c4ef-d23c-4d3f-a7771ce56bab@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).