From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E03EC43460 for ; Thu, 1 Apr 2021 07:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3985061029 for ; Thu, 1 Apr 2021 07:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233427AbhDAHp3 (ORCPT ); Thu, 1 Apr 2021 03:45:29 -0400 Received: from mga07.intel.com ([134.134.136.100]:2550 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230284AbhDAHpK (ORCPT ); Thu, 1 Apr 2021 03:45:10 -0400 IronPort-SDR: AozoHmkV2Kuj+SszmoaH6YXXMfIzJA/FuY+l0a7przeTicEXJZvrqRkd8WN52X6FhSm4Ms9Ir5 nBKnyh3W3xqA== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="256160553" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="256160553" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 00:45:07 -0700 IronPort-SDR: lsbWgO8aRTgEJJiGUMpmyaRbtmcauxhMmNapB9ei3jfvohdyrNPtGYFBZQe67fxtzdYtxYWhU7 9g+tDZ9olIrw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="377598402" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.174]) ([10.237.72.174]) by orsmga003.jf.intel.com with ESMTP; 01 Apr 2021 00:45:00 -0700 Subject: Re: [PATCH v14 1/2] scsi: ufs: Enable power management for wlun To: "Asutosh Das (asd)" , cang@codeaurora.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , Pedro Sousa , Krzysztof Kozlowski , Stanley Chu , Andy Gross , Bjorn Andersson , Steven Rostedt , Ingo Molnar , Matthias Brugger , Lee Jones , Bean Huo , Kiwoong Kim , Yue Hu , Dan Carpenter , Wei Yongjun , Bart van Assche , "Gustavo A. R. Silva" , Dinghao Liu , Jaegeuk Kim , Satya Tangirala , open list , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." References: <16f1bcf76ff411c70fe0e3e13f84e4b0fa7d9063.1617143113.git.asutoshd@codeaurora.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <612d0f35-89a2-947b-9fa4-608624c4c032@intel.com> Date: Thu, 1 Apr 2021 10:45:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/04/21 4:40 am, Asutosh Das (asd) wrote: > On 3/31/2021 11:19 AM, Adrian Hunter wrote: >> On 31/03/21 1:31 am, Asutosh Das wrote: >>> During runtime-suspend of ufs host, the scsi devices are >>> already suspended and so are the queues associated with them. >>> But the ufs host sends SSU (START_STOP_UNIT) to wlun >>> during its runtime-suspend. >>> During the process blk_queue_enter checks if the queue is not in >>> suspended state. If so, it waits for the queue to resume, and never >>> comes out of it. >>> The commit >>> (d55d15a33: scsi: block: Do not accept any requests while suspended) >>> adds the check if the queue is in suspended state in blk_queue_enter(). >>> >>> Call trace: >>>   __switch_to+0x174/0x2c4 >>>   __schedule+0x478/0x764 >>>   schedule+0x9c/0xe0 >>>   blk_queue_enter+0x158/0x228 >>>   blk_mq_alloc_request+0x40/0xa4 >>>   blk_get_request+0x2c/0x70 >>>   __scsi_execute+0x60/0x1c4 >>>   ufshcd_set_dev_pwr_mode+0x124/0x1e4 >>>   ufshcd_suspend+0x208/0x83c >>>   ufshcd_runtime_suspend+0x40/0x154 >>>   ufshcd_pltfrm_runtime_suspend+0x14/0x20 >>>   pm_generic_runtime_suspend+0x28/0x3c >>>   __rpm_callback+0x80/0x2a4 >>>   rpm_suspend+0x308/0x614 >>>   rpm_idle+0x158/0x228 >>>   pm_runtime_work+0x84/0xac >>>   process_one_work+0x1f0/0x470 >>>   worker_thread+0x26c/0x4c8 >>>   kthread+0x13c/0x320 >>>   ret_from_fork+0x10/0x18 >>> >>> Fix this by registering ufs device wlun as a scsi driver and >>> registering it for block runtime-pm. Also make this as a >>> supplier for all other luns. That way, this device wlun >>> suspends after all the consumers and resumes after >>> hba resumes. >>> >>> Co-developed-by: Can Guo >>> Signed-off-by: Can Guo >>> Signed-off-by: Asutosh Das >>> --- >> > Hi Adrian > Thanks for the comments. >> Looks good but still doesn't seem to based on the latest tree. >> > Umm, it's based on the below: > git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git > Branch: refs/heads/for-next > > The top most change is e27f3c8 on 27th March'21. > Which tree are you referring to that'd be latest? Dunno, but that seems to be missing: commit aa53f580e67b49ec5f4d9bd1de81eb9eb0dc079f Author: Can Guo Date: Tue Feb 23 21:36:47 2021 -0800 scsi: ufs: Minor adjustments to error handling which is in v5.12-rc3 > >> Also came across the issue below: >> >> >> >>> +#ifdef CONFIG_PM_SLEEP >>> +static int ufshcd_wl_poweroff(struct device *dev) >>> +{ >>> +    ufshcd_wl_shutdown(dev); >> >> This turned out to be wrong.  This is a PM op and SCSI has already >> quiesced the sdev's.  All that is needed isOk. I'll fix it in the next version. > >> >>     __ufshcd_wl_suspend(hba, UFS_SHUTDOWN_PM); >> >>> +    return 0; >>> +} >>> +#endif > >