From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
Cc: Corentin Labbe <clabbe@baylibre.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: media: zoran: Deleted dead code
Date: Fri, 22 Jul 2022 20:52:29 +0200 [thread overview]
Message-ID: <614ce7e3-ff4e-5d76-e940-2aa222535743@gmail.com> (raw)
In-Reply-To: <20220722182622.23719-1-abhijeet.srivastava2308@gmail.com>
On 7/22/22 20:26, Abhijeet Srivastava wrote:
> Deleted part of code in block comment
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
> drivers/staging/media/zoran/zoran_driver.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index b408c1d4e0a7..836edf623571 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> .vidioc_enum_input = zoran_enum_input,
> .vidioc_g_input = zoran_g_input,
> .vidioc_s_input = zoran_s_input,
> -
> -/* .vidioc_enum_output = zoran_enum_output,
> - * .vidioc_g_output = zoran_g_output,
> - * .vidioc_s_output = zoran_s_output,
> - */
> .vidioc_g_std = zoran_g_std,
> .vidioc_s_std = zoran_s_std,
> .vidioc_create_bufs = vb2_ioctl_create_bufs,
> @@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> .vidioc_streamon = vb2_ioctl_streamon,
> .vidioc_streamoff = vb2_ioctl_streamoff,
> .vidioc_enum_fmt_vid_cap = zoran_enum_fmt_vid_cap,
> -/* .vidioc_enum_fmt_vid_out = zoran_enum_fmt_vid_out,*/
> .vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap,
> -/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/
> .vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap,
> -/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/
> .vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap,
> -/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/
> .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
> .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> };
Why does the subject line start with "media:" The subsystem is
"staging:" so the subject should start with "staging: media: ..."
I have no clue if this is accepted.
Regards,
Philipp
next prev parent reply other threads:[~2022-07-22 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 18:26 [PATCH] media: staging: media: zoran: Deleted dead code Abhijeet Srivastava
2022-07-22 18:52 ` Philipp Hortmann [this message]
2022-07-22 19:25 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614ce7e3-ff4e-5d76-e940-2aa222535743@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=abhijeet.srivastava2308@gmail.com \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).