From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF39AC433DB for ; Wed, 13 Jan 2021 12:41:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80A642339F for ; Wed, 13 Jan 2021 12:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727067AbhAMMlx (ORCPT ); Wed, 13 Jan 2021 07:41:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45040 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbhAMMlw (ORCPT ); Wed, 13 Jan 2021 07:41:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610541625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fZ+YcApOL1FyWbUbySK29mXu2RIMEwNXmpAvze3hxpQ=; b=MLsfJQOrkSvdYQCwOGs7x/PW+BxpN1teIrNDAJwRLr8kaVtS35PB3RdF/g0SEmrNH7f+W1 wKuejsGlH+9UrlSZ00OQYBl9FaaH4iNoOiafDKLW2ueX5Aabx/JipMOGArvkiOFego3gIX 7BTfPDIrf8ud67ZOy1se7MpJGkbyeOk= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-IawebCahMmCwNqA3iCwIhQ-1; Wed, 13 Jan 2021 07:40:23 -0500 X-MC-Unique: IawebCahMmCwNqA3iCwIhQ-1 Received: by mail-ed1-f70.google.com with SMTP id p17so783856edx.22 for ; Wed, 13 Jan 2021 04:40:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fZ+YcApOL1FyWbUbySK29mXu2RIMEwNXmpAvze3hxpQ=; b=mj1JioBRkfisU/8bYvqq5d7XU8VSJixgTMcHpNm8kLftATIGR6uYh9Tph0Y9UFBG/T a/5kLXPP0R8z5HuuyeJ6LRAtadybFuNkpugK/tKyTjZC+PlL/0cT385GDpwfVSkxe7+r nybl2m8bftryciCqk6q7yDXW2rIuS6kVoMVvxmIvZ9WQ9hvKegUntUgtrM4C7ei6twu3 YfseRvf2HN/8VcKG+e9pWqS0DvwA6z3sThLcQWdzpnpKT701mGymtYmbxVsDL1an4eUA uxB7pC1XZ6eizFklQzRkASMKo3ZkQgs3RJqjWkpoY29JorqSW5vCXDpb0ZrlCo2ma/+m uhTg== X-Gm-Message-State: AOAM531+xkZ/f+L8aNyo6LZHyoTZtoHhQDcnqPhrSR8m2cj6Lc8m7lbJ CF9uJ005wXECrwYk1z9w1XCWVG9IQhPSMjuKE29lRizlUqnHCCBIMphIk4gpbmmHm+35eTeJuQH KCo72QMPYkizMTB8bMYHKwwBr X-Received: by 2002:a17:906:d19b:: with SMTP id c27mr1456538ejz.234.1610541622670; Wed, 13 Jan 2021 04:40:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBxb43X8rAHWK+3MIYiYYqUJPhoX/hIjXwpQROEnILuJ7vX2lEjEloOcqruZqwlFH5PoG5DQ== X-Received: by 2002:a17:906:d19b:: with SMTP id c27mr1456525ejz.234.1610541622538; Wed, 13 Jan 2021 04:40:22 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id u2sm669767ejb.65.2021.01.13.04.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jan 2021 04:40:21 -0800 (PST) To: Sean Christopherson , Wei Huang Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, vkuznets@redhat.com, joro@8bytes.org, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, jmattson@google.com, wanpengli@tencent.com, bsd@redhat.com, dgilbert@redhat.com, mlevitsk@redhat.com References: <20210112063703.539893-1-wei.huang2@amd.com> From: Paolo Bonzini Subject: Re: [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions Message-ID: <61622212-4f7a-bf24-dab2-a40f2142835d@redhat.com> Date: Wed, 13 Jan 2021 13:40:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/21 18:59, Sean Christopherson wrote: >> It would be very helpful to list exactly which CPUs are/aren't affected, even if >> that just means stating something like "all CPUs before XYZ". Given patch 2/2, >> I assume it's all CPUs without the new CPUID flag? > Ah, despite calling this an 'errata', the bad behavior is explicitly documented > in the APM, i.e. it's an architecture bug, not a silicon bug. I would still call it an errata for the case when virtualized VMSAVE/VMLOAD is enabled (and therefore VMLOAD intercepts are disabled). In that case, the problem is that the GPA does not go through NPT before it is checked against *host* reserved memory regions. In fact I hope that, on processors that have the fix, VMSAVE/VMLOAD from guest mode _does_ check the GPA after it's been translated! Paolo