From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935160AbcIXTEv (ORCPT ); Sat, 24 Sep 2016 15:04:51 -0400 Received: from mout.web.de ([217.72.192.78]:64629 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754707AbcIXTEt (ORCPT ); Sat, 24 Sep 2016 15:04:49 -0400 Subject: Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val() To: Dmitry Torokhov References: <566ABCD9.1060404@users.sourceforge.net> <92cc52f5-c5e1-cafe-76f2-04e4ed997735@users.sourceforge.net> <2a1f52e8-a502-1d4b-d9c9-e806cc6f246e@users.sourceforge.net> <56e70dc1-e36c-3492-d481-cef1e8262393@users.sourceforge.net> <20160924183455.GD40187@dtor-ws> Cc: "linux-input@vger.kernel.org" , Henrik Rydberg , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <616d6d8d-a5ac-a6ec-d61b-e14224f60ed1@users.sourceforge.net> Date: Sat, 24 Sep 2016 21:04:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160924183455.GD40187@dtor-ws> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:xypyeIr+WHbAgcg5CpFu7Fed75HZ5YTYoFlxmwgoSMWkFQXoGzP FmZ18S+kqBf/EI8vDyddkTfuqy2HJTSQ9vAVV8pFpLQmkuU694OUdifh6noB1NgwHSgOlrx h4lUJz2fwqx1w/kXCRq3J/b5alMrdV/FCAGo7rdcZ22uWAqFNQEzkO8aMmqVkOpkOrwVFFY 7E7PxK4t7NxPivhT75BrA== X-UI-Out-Filterresults: notjunk:1;V01:K0:zPzP0F4FgNs=:X0kk73iqeTnFEQSOxFd3pJ T2jI0gflMZQusWAgaaWF6dL5km5OYIXFoMUqjJQ7HAWAWwBlZTnzBmGqyy6EYmAAFQRn8kTTt t/VO8L4sl4BcysuYxRRDRHDceDmMKMZ/vRWURPMVxmu7TQoiGCV2iwKATNSj6GEqztd7tC3Rj FEPCx/zzXlatD9je8znd8ptLAX1oJlXzxStmAsHnkhMMPBlfuCrjAApNrzTg/OKIi2KoanMFa esRRTphfO5yOzu/zyCWY2H49aKlBdS2aszducS3wY+XTcTjCBDGYiHMV7a5ppMYvIROYVxsMw u+Uc7BbrGCN1eBM1UFifjjSqWN7HhULDHDaWtLmKvY+hAQIwdCYwvDV2OFrNJhRGKVEMAAwwq nGhtYhg5VFl9yt739dHaROsapApdbKUTuFtpWRPulqGPpFSZtARh6/v+G7GxIb74WFpA5LnlN 5Apjx3A9f4Uhco5XKaEC4XIuI1b31tZx5UAypmhAimFBpeoDjJPKS1rKPpmuNayvo05/IAFbj /RG1Cjhu/08LhbeNNmQnSZMHucuNgLHQyVfLy64Q+kFTKRv5/e/JrC3Mc0VE5EeEbJuiqmvZ3 SGpGwC2Qm+WBpXkyEPzKa3/y2wR3oCKnChBy02rnSb45W6MN6mRhoxBngKZJgpSb76G5AGraK 4GIbT14gMPTZOVOdQVLBHStvfpagaUZhw4dxgo0U8BClK1ibBYQ/heObvxir+r53J+xNWGgko LqjYHRfX01k6fAD1NUEdRaOfNSzDTNMVeFQ4B2i9J3Tp2pkqzV4H12CNRdQp+tG8jGliyviX3 8J+nRE6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Again, what is the purpose of the changes? I came also along a few source code places where their maintainers requested the usage of a function like "kmalloc_array". How do you think about to clarify the consistent use of programming interfaces for Linux a bit more? > Are you working on the code I am trying to improve various free software (including Linux). > and the fact that the driver is older-style hinders your progress? Not for me directly. > Or there are runtime improvements from your changes? It depends on some factors. Can an array memory allocator organise the desired data in a safer and more efficient way than a "default approach"? > Correctness issues? This can be. Do you care for source code annotations? > I do not very much appreciate changes just to satisfy checkpatch rule > du jour. Do these rules contain knowledge which you give a significant value? Regards, Markus