From: Shuah Khan <skhan@linuxfoundation.org>
To: Trevor Woerner <twoerner@gmail.com>, linux-kernel@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>,
Jiri Kosina <trivial@kernel.org>, Joe Perches <joe@perches.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Miguel Ojeda <ojeda@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Yorick de Wid <yorickdewid@users.noreply.github.com>,
Dan Williams <dan.j.williams@intel.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros
Date: Fri, 23 Apr 2021 12:54:19 -0600 [thread overview]
Message-ID: <616ec71e-8ca1-c31d-80e2-c064864678a9@linuxfoundation.org> (raw)
In-Reply-To: <20210423184012.39300-1-twoerner@gmail.com>
On 4/23/21 12:40 PM, Trevor Woerner wrote:
> The dev_printk()-like functions moved to include/linux/dev_print.h in
> commit af628aae8640 ("device.h: move dev_printk()-like functions to
> dev_printk.h").
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> Documentation/process/coding-style.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 42969ab37b34..44f796ba52c4 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period.
>
> Printing numbers in parentheses (%d) adds no value and should be avoided.
>
> -There are a number of driver model diagnostic macros in <linux/device.h>
> +There are a number of driver model diagnostic macros in <linux/dev_printk.h>
> which you should use to make sure messages are matched to the right device
> and driver, and are tagged with the right level: dev_err(), dev_warn(),
> dev_info(), and so forth. For messages that aren't associated with a
>
Looks good to me. Thanks for catching this.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2021-04-23 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 18:40 [PATCH] coding-style.rst: trivial: fix location of driver model macros Trevor Woerner
2021-04-23 18:54 ` Shuah Khan [this message]
2021-04-23 19:14 ` Miguel Ojeda
[not found] ` <CAHUNapQfFBcqrX7MvUvq8qbPgk2bPu-h3+9NxAUFpRtpOGFODw@mail.gmail.com>
2021-10-26 12:47 ` Miguel Ojeda
2021-10-26 14:44 ` Trevor Woerner
2021-10-26 15:10 ` Miguel Ojeda
2021-10-26 15:18 ` Randy Dunlap
2021-10-26 15:27 ` Joe Perches
2021-10-26 23:49 ` Randy Dunlap
2021-10-26 15:28 ` Miguel Ojeda
2021-10-26 15:37 ` Joe Perches
2021-10-26 21:21 ` Trevor Woerner
2021-10-26 15:41 ` Jonathan Corbet
2021-10-26 21:23 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616ec71e-8ca1-c31d-80e2-c064864678a9@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=geert@linux-m68k.org \
--cc=grandmaster@al2klimov.de \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ojeda@kernel.org \
--cc=trivial@kernel.org \
--cc=twoerner@gmail.com \
--cc=yorickdewid@users.noreply.github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).