From: John Hubbard <jhubbard@nvidia.com>
To: Jan Kara <jack@suse.cz>, <john.hubbard@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>,
Al Viro <viro@zeniv.linux.org.uk>, <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm: introduce put_user_page(), placeholder version
Date: Wed, 3 Oct 2018 16:23:44 -0700 [thread overview]
Message-ID: <6178c173-ffbf-700b-f140-e4b184a5767e@nvidia.com> (raw)
In-Reply-To: <20181003162237.GH24030@quack2.suse.cz>
On 10/3/18 9:22 AM, Jan Kara wrote:
> On Thu 27-09-18 22:39:48, john.hubbard@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
>>
>> Introduces put_user_page(), which simply calls put_page().
>> This provides a way to update all get_user_pages*() callers,
>> so that they call put_user_page(), instead of put_page().
>>
>> Also adds release_user_pages(), a drop-in replacement for
>> release_pages(). This is intended to be easily grep-able,
>> for later performance improvements, since release_user_pages
>> is not batched like release_pages() is, and is significantly
>> slower.
>
> A small nit but can we maybe call this put_user_pages() for symmetry with
> put_user_page()? I don't really care too much but it would look natural to
> me.
>
Sure. It started out as "make it a drop-in replacement for release_pages()",
but now it's not quite a drop-in replacement anymore. And in any case it's an
opportunity to make the name more intuitive, so that seems like a good
idea.
If anyone hates put_user_pages() and wants to campaign relentlessly for
release_pages*(), then now is the time! :)
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2018-10-03 23:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 5:39 [PATCH 0/4] get_user_pages*() and RDMA: first steps john.hubbard
2018-09-28 5:39 ` [PATCH 1/4] mm: get_user_pages: consolidate error handling john.hubbard
2018-09-28 5:39 ` [PATCH 3/4] infiniband/mm: convert to the new put_user_page() call john.hubbard
2018-09-28 15:39 ` Jason Gunthorpe
2018-09-29 3:12 ` John Hubbard
2018-09-29 16:21 ` Matthew Wilcox
2018-09-29 19:19 ` Jason Gunthorpe
2018-10-01 12:50 ` Christoph Hellwig
2018-10-01 15:29 ` Matthew Wilcox
2018-10-01 15:51 ` Christoph Hellwig
2018-10-01 14:35 ` Dennis Dalessandro
2018-10-03 5:40 ` John Hubbard
2018-10-03 16:27 ` Jan Kara
2018-10-03 23:19 ` John Hubbard
2018-09-28 5:39 ` [PATCH 2/4] mm: introduce put_user_page(), placeholder version john.hubbard
2018-10-03 16:22 ` Jan Kara
2018-10-03 23:23 ` John Hubbard [this message]
2018-09-28 5:39 ` [PATCH 4/4] goldfish_pipe/mm: convert to the new release_user_pages() call john.hubbard
2018-09-28 15:29 ` [PATCH 0/4] get_user_pages*() and RDMA: first steps Jerome Glisse
2018-09-28 19:06 ` John Hubbard
2018-09-28 21:49 ` Jerome Glisse
2018-09-29 2:28 ` John Hubbard
2018-09-29 8:46 ` Jerome Glisse
2018-10-01 6:11 ` Dave Chinner
2018-10-01 12:47 ` Christoph Hellwig
2018-10-02 1:14 ` Dave Chinner
2018-10-03 16:21 ` Jan Kara
2018-10-01 15:31 ` Jason Gunthorpe
2018-10-03 16:08 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6178c173-ffbf-700b-f140-e4b184a5767e@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=john.hubbard@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).