From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1072DC433DF for ; Mon, 29 Jun 2020 18:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF03F204EC for ; Mon, 29 Jun 2020 18:59:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730258AbgF2S7F convert rfc822-to-8bit (ORCPT ); Mon, 29 Jun 2020 14:59:05 -0400 Received: from mga09.intel.com ([134.134.136.24]:65099 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbgF2S6y (ORCPT ); Mon, 29 Jun 2020 14:58:54 -0400 IronPort-SDR: eKoD8V2wqTWUE0QfvlcDWBj2fUJGp1JQFAZEWCcOdd9RB6Iz2k79WYN3SDqzCHfZ5x5HJtYUrS TCxYV5wPo5rQ== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="147558727" X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="147558727" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 10:18:48 -0700 IronPort-SDR: PfovTJ7ctRVVTVNzrBgATY6YChrZ/17qHIHtYJnPMMZEpZLRlO/kZ9uRGO0xFF6kZv7z2obVoF C6l1q1l38H6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="424885466" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga004.jf.intel.com with ESMTP; 29 Jun 2020 10:18:47 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.199]) by ORSMSX106.amr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000; Mon, 29 Jun 2020 10:18:47 -0700 From: "Kirsher, Jeffrey T" To: Bartosz Golaszewski , "David S . Miller" , Jakub Kicinski , John Crispin , Sean Wang , Mark Lee , Matthias Brugger , "Heiner Kallweit" , Andrew Lunn , "Florian Fainelli" , Russell King , "Rob Herring" , Frank Rowand CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Bartosz Golaszewski Subject: RE: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free() Thread-Topic: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free() Thread-Index: AQHWTg2KqoUStuk1GEW2zcU3EcxbWKjv1lQw Date: Mon, 29 Jun 2020 17:18:46 +0000 Message-ID: <61CC2BC414934749BD9F5BF3D5D940449874064D@ORSMSX112.amr.corp.intel.com> References: <20200629120346.4382-1-brgl@bgdev.pl> <20200629120346.4382-3-brgl@bgdev.pl> In-Reply-To: <20200629120346.4382-3-brgl@bgdev.pl> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Bartosz Golaszewski > Sent: Monday, June 29, 2020 05:04 > To: Kirsher, Jeffrey T ; David S . Miller > ; Jakub Kicinski ; John Crispin > ; Sean Wang ; Mark Lee > ; Matthias Brugger > ; Heiner Kallweit ; Andrew > Lunn ; Florian Fainelli ; Russell King > ; Rob Herring ; Frank Rowand > > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; > devicetree@vger.kernel.org; Bartosz Golaszewski > > Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call > devm_mdiobus_free() > > From: Bartosz Golaszewski > > The idea behind devres is that the release callbacks are called if probe fails. As > we now check the return value of ixgbe_mii_bus_init(), we can drop the call > devm_mdiobus_free() in error path as the release callback will be called > automatically. > > Signed-off-by: Bartosz Golaszewski Acked-by: Jeff Kirsher > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-)