From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753357AbdBRLeD (ORCPT ); Sat, 18 Feb 2017 06:34:03 -0500 Received: from mo4-p04-ob.smtp.rzone.de ([81.169.146.176]:30136 "EHLO mo4-p04-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdBRLd7 (ORCPT ); Sat, 18 Feb 2017 06:33:59 -0500 X-RZG-CLASS-ID: mo04 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKID8+PFGmLic= Subject: Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_60AA252B-712D-4C70-B92B-95CD25A02105"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Pgp-Agent: GPGMail From: "H. Nikolaus Schaller" In-Reply-To: <20170218091526.GC8937@amd> Date: Sat, 18 Feb 2017 12:33:42 +0100 Cc: Dmitry Torokhov , Sebastian Reichel , Mark Rutland , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Russell King , Arnd Bergmann , Michael Welling , =?utf-8?Q?Mika_Penttil=C3=A4?= , Javier Martinez Canillas , Igor Grinberg , "Andrew F. Davis" , Mark Brown , Jonathan Cameron , Rob Herring , Alexander Stein , Eric Engestrom , Hans de Goede , Benjamin Tissoires , Petr Cvek , Mauro Carvalho Chehab , Hans Verkuil , Nick Dyer , Siebren Vroegindeweij , Michel Verlaan , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, letux-kernel@openphoenux.org, linux-iio@vger.kernel.org, kernel@pyra-handheld.com, Aaro Koskinen , =?utf-8?Q?Pali_Roh=C3=A1r?= , Andrey Gelman , Haibo Chen Message-Id: <61F3C580-4BF2-4EE6-9DEC-FB8634434EC0@goldelico.com> References: <9830dd21e6425e3a866fac6ed4cc73ddd58b719f.1482936802.git.hns@goldelico.com> <20170128193342.GB38136@dtor-ws> <1F6355E1-A5E3-41A6-908F-619A15581BEF@goldelico.com> <20170217204041.GE13050@dtor-ws> <20170218091526.GC8937@amd> To: Pavel Machek X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Apple-Mail=_60AA252B-712D-4C70-B92B-95CD25A02105 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Pavel, > Am 18.02.2017 um 10:15 schrieb Pavel Machek : >=20 > Hi! >=20 >>> Well, there is some historic confusion wether this driver reports = resistance >>> or pressure. >>>=20 >>> The unpatched tsc2007 driver does it wrong (please test!) and we fix = it on >>> the fly (because a separate patch is much more complex than doing it = right >>> immediately). >>>=20 >>> This ti,report-resistance property is a means to get the old (wrong) = meaning back >>> in case someone urgently needs it and can't fix the user-space = workaround which >>> he must be using. >>>=20 >>>=20 >>> AFAIK there is no mainline board using the DT except ours (and the = upcoming >>> OMAP5-Pyra), so we shouldn't care too much. If you prefer, you can = remove this >>> compatibility property. We don't need it for our devices. >=20 > N900 is mainline and uses DT. Yes, but it does not use the tsc2007 and will not be influenced at all = by this patch. >=20 >>> That the function name is wrong is a second issue and this double = negation might >>> confuse a litte. >>>=20 >>> Please test on a real device if the patched driver reports pressure = now (unless >>> ti,report-resistance is specified). >>=20 >> I unfortunately can not test this driver as I do not have the = hardware. >> So all my observations are from code and data sheets. >>=20 >> That said, what is the values emitted as ABS_PRESSURE when finger is = not >> touching the device, barely touching the device, or pressing firmly? >> It seems that between TSC2007, TSC2004, TSC2005, and ADS7846, we have >> confusion as to what is being reported. >>=20 >> I am adding a few more folks to the CC so we can try and soft this = out. >> Sebastian, Pali, Pavel, any input here? >=20 > X work ok on N900. Nikolaus wrote rather long email, but I'm not what > the meaning is and what is supposed to be broken there. IMHO it is broken that you have to do a subtle calibration step in = user-space and repeat it for different GUI toolkits. >=20 > I do this on X startup: >=20 > xinput --set-prop --type=3Dfloat "TSC200X touchscreen" "Coordinate = Transformation Matrix" 1.10 0.00 -0.05 0.00 1.18 -0.10 0.00 0.00 1.00 > xinput --set-prop --type=3Dint "TSC200X touchscreen" "Evdev Axis = Inversion" 0 1 > xinput --set-prop --type=3Dfloat "TSC2005 touchscreen" "Coordinate = Transformation Matrix" 1\ > .10 0.00 -0.05 0.00 1.18 -0.10 0.00 0.00 1.00 > xinput --set-prop --type=3Dint "TSC2005 touchscreen" "Evdev Axis = Inversion" 0 1 Wouldn't it be nice to get rid of this completely, because the = DT/kernel knows these factors? Especially since they are well defined by the hardware? >=20 > And I agree that kernel should _not_ attempt rescaling itself, as it > would lose precision. With an almost 1:1 mapping you won't loose precision. > Providing default calibration info is ok. IMHO it is missing one step of automation. BR and thanks, Nikolaus --Apple-Mail=_60AA252B-712D-4C70-B92B-95CD25A02105 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYqDEWAAoJEIl79TGLgAm6BxkQALa1Vx5764oOSK/GGmnIDGR9 2X4lsqQQTO1zAC/0iF/Klgp0n1nL92ygdv/6xh7inwFq5OSp/gEzTf0rdWgSRmk2 pMPicns5hmOXudPOE1tNKCBpXJY3XtjPk3NhN84gF2i3+bKD5JqYa2Zo1PBTA4Wz xG9d+NBCmoxXLmejA6ot7gYCld2Mg/ZPjnKkdCi/BCPp0ZyIK9LWB1YspqcTNRYn fhJHqaBqKZgEFeCWeesLrAMhOvDBDpHfXKT2ckbrSu0LNdOrXZUOuUzqO+SFPtHu Buob2uun8bbz324e6AafWuw6RDoLIg7dDaEBFJP99QVXbewN1dmqSUm0/JZJDlpm 5xy1QuLe5QYxqk2MwJwBOqxpC0tZgPAPrNoqotPP5rygJ90QLOkTDkTGhZt+JEtH n+YrPBvuG31cjcUWzf/VmO13sNnU0CrKkcNbrDPUt+X3uIFYhue+MSgx7kkQnd71 aXDXL3450KVFZ+0xrIrk292dkC1s8AU5CyXDHuMFX3YIp1mgi+g3xJSPA8S8AlLq DsfDpbMedFR+/ZWMImstg91UCab7q7wyhK6N+s4c6soeQfMtK6vW/0t9FqrHsf44 AHfhz0SBRhqyzDLsPpTZGRBnCMKIShdHUlH56wD3rdHgfPLuLillV4q+BfxZjBcv gvTXRiWDhhAf/jDQo7iK =VezH -----END PGP SIGNATURE----- --Apple-Mail=_60AA252B-712D-4C70-B92B-95CD25A02105--