From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Július Milan" <jmilan.dev@gmail.com>, linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
gregkh@linuxfoundation.org, ajay.kathat@microchip.com,
adham.abozaeid@microchip.com
Subject: Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32
Date: Sat, 5 Jan 2019 10:02:23 -0600 [thread overview]
Message-ID: <61a272a5-3c6f-4e69-2ce9-b7c58b427750@lwfinger.net> (raw)
In-Reply-To: <20190105091025.GA28917@localhost.localdomain>
On 1/5/19 3:10 AM, Július Milan wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/wilc1000/host_interface.c:2360:30: warning:
> incorrect type in assignment (different base types)
> expected restricted __le32 [addressable] [assigned] [usertype] frame_type
> got restricted __le16 [usertype] <noident>
>
> Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
> Signed-off-by: Július Milan <jmilan.dev@gmail.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 5dae6e7155d3..07c3d6293573 100644
> --- a/struct wilc_reg_frame
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -2357,7 +2357,7 @@ void wilc_frame_register(struct wilc_vif *vif, u16 frame_type, bool reg)
> default:
> break;
> }
> - reg_frame.frame_type = cpu_to_le16(frame_type);
> + reg_frame.frame_type = cpu_to_le32(frame_type);
> result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
> wilc_get_vif_idx(vif));
> if (result)
Before you send V3, are you sure this is the correct fix? As "frame_type" is
input as u16, it seems to me that the frame_type member of struct wilc_reg_frame
should be __le16, not __le32.
Larry
next prev parent reply other threads:[~2019-01-05 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 9:10 [PATCH v2] staging: wilc1000: fix cast to restricted __le32 Július Milan
2019-01-05 9:16 ` Greg KH
2019-01-05 16:02 ` Larry Finger [this message]
2019-01-06 7:18 ` Július Milan
2019-01-07 6:06 ` Ajay.Kathat
2019-01-07 14:48 ` Július Milan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61a272a5-3c6f-4e69-2ce9-b7c58b427750@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=adham.abozaeid@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmilan.dev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).