From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9E2C2BA1A for ; Fri, 24 Apr 2020 09:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D40A20728 for ; Fri, 24 Apr 2020 09:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbgDXJYu (ORCPT ); Fri, 24 Apr 2020 05:24:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726298AbgDXJYu (ORCPT ); Fri, 24 Apr 2020 05:24:50 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56F0BC09B045; Fri, 24 Apr 2020 02:24:50 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1jRuZd-00FRKL-4g; Fri, 24 Apr 2020 11:24:41 +0200 Message-ID: <61c8c547b9148b8297aa946a93df23608f408d28.camel@sipsolutions.net> Subject: Re: [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for RCU list usage From: Johannes Berg To: madhuparnabhowmik10@gmail.com, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Date: Fri, 24 Apr 2020 11:24:40 +0200 In-Reply-To: <20200409082925.27481-1-madhuparnabhowmik10@gmail.com> (sfid-20200409_102943_941405_F4B3E85F) References: <20200409082925.27481-1-madhuparnabhowmik10@gmail.com> (sfid-20200409_102943_941405_F4B3E85F) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-04-09 at 13:59 +0530, madhuparnabhowmik10@gmail.com wrote: > From: Madhuparna Bhowmik > > ieee80211_add_vht_ie() is called with sdata->wdev.mtx held from > ieee80211_send_assoc(). Add lockdep condition to avoid false positive > warnings. Again, wrong lock! Over the course of the three patches, you've now claimed that any one of * RTNL, * local->iflist_mtx, * local->mtx, and * sdata->wdev.mtx are sufficient to iterate the interface list, but only the first two are really true. johannes