linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Sanchayan Maity <maitysanchayan@gmail.com>,
	shawn.guo@linaro.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 2/2] ARM: vf610: Add SoC bus support for Vybrid
Date: Wed, 20 May 2015 09:36:38 +0200	[thread overview]
Message-ID: <61cec15fe896133ee6e102b0242fb43d@agner.ch> (raw)
In-Reply-To: <9691074.oWRy1bscbz@wuerfel>

On 2015-05-20 09:12, Arnd Bergmann wrote:
> On Wednesday 20 May 2015 11:06:52 Sanchayan Maity wrote:
>> Implements SoC bus support to export SoC specific information. Read
>> the unique SoC ID from the Vybrid On Chip One Time Programmable
>> (OCOTP) controller, SoC specific information from the Miscellaneous
>> System Control Module (MSCM), revision from the ROM revision register
>> and expose it via the SoC bus infrastructure.
>>
>> Sample Output:
>>
>> root@vf:/sys/devices/soc0# cat soc_id
>> df63c12a2e2161d4
>> root@vf:/sys/devices/soc0# cat family
>> Freescale Vybrid VF500
>> root@vf:/sys/devices/soc0# cat revision
>> 00000013
>> root@vf:/sys/devices/soc0# cat machine
>> Freescale Vybrid
>>
> 
> I would prefer to see this as a driver in drivers/soc that registers
> to a platform device. Is there any DT node that would be a reasonable
> device to bind to?

Hm, what is a viable device? Probably the most SoC specific device in
the SoC? Currently, all three devices we read from do have a
vf610-something compatible string, hence would be SoC specific (ocotp,
ocrom and mscm-cpucfg). Probably the last is the most SoC specific...

But somehow bind to just a random device sounds wrong to me. Couldn't we
add a more specific compatible string to the soc node and bind to that?

--
Stefan

  reply	other threads:[~2015-05-20  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  5:36 [PATCH v2 0/2] Implement SoC bus support for Vybrid Sanchayan Maity
2015-05-20  5:36 ` [PATCH v2 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes Sanchayan Maity
2015-05-20  5:36 ` [PATCH v2 2/2] ARM: vf610: Add SoC bus support for Vybrid Sanchayan Maity
2015-05-20  7:12   ` Arnd Bergmann
2015-05-20  7:36     ` Stefan Agner [this message]
2015-05-20  8:18       ` Arnd Bergmann
2015-05-20  6:08 ` [PATCH v2 0/2] Implement " Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61cec15fe896133ee6e102b0242fb43d@agner.ch \
    --to=stefan@agner.ch \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).