From: Shreeya Patel <shreeya.patel@collabora.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
chao@kernel.org, krisman@collabora.com, ebiggers@google.com,
drosen@google.com, ebiggers@kernel.org, yuchao0@huawei.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, kernel@collabora.com,
andre.almeida@collabora.com
Subject: Re: [PATCH v8 4/4] fs: unicode: Add utf8 module and a unicode layer
Date: Tue, 27 Apr 2021 15:39:15 +0530 [thread overview]
Message-ID: <61d85255-d23e-7016-7fb5-7ab0a6b4b39f@collabora.com> (raw)
In-Reply-To: <20210427062907.GA1564326@infradead.org>
On 27/04/21 11:59 am, Christoph Hellwig wrote:
> On Sat, Apr 24, 2021 at 02:21:36AM +0530, Shreeya Patel wrote:
>> utf8data.h_shipped has a large database table which is an auto-generated
>> decodification trie for the unicode normalization functions.
>> We can avoid carrying this large table in the kernel unless it is required
>> by the filesystem during boot process.
>>
>> Hence, make UTF-8 encoding loadable by converting it into a module and
>> also add built-in UTF-8 support option for compiling it into the
>> kernel whenever required by the filesystem.
> The way this is implemement looks rather awkward.
>
> Given that the large memory usage is for a data table and not for code,
> why not treat is as a firmware blob and load it using request_firmware?
utf8 module not just has the data table but also has some kernel code.
The big part that we are trying to keep out of the kernel is a tree
structure that gets traversed based on a key that is the file name.
This is done when issuing a lookup in the filesystem, which has to be
very fast. So maybe it would not be so good to use request_firmware for
such a core feature.
next prev parent reply other threads:[~2021-04-27 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 20:51 [PATCH v8 0/4] Make UTF-8 encoding loadable Shreeya Patel
2021-04-23 20:51 ` [PATCH v8 1/4] fs: unicode: Use strscpy() instead of strncpy() Shreeya Patel
2021-04-23 20:51 ` [PATCH v8 2/4] fs: unicode: Rename function names from utf8 to unicode Shreeya Patel
2021-04-23 20:51 ` [PATCH v8 3/4] fs: unicode: Rename utf8-core file to unicode-core Shreeya Patel
2021-04-23 20:51 ` [PATCH v8 4/4] fs: unicode: Add utf8 module and a unicode layer Shreeya Patel
2021-04-27 6:29 ` Christoph Hellwig
2021-04-27 10:09 ` Shreeya Patel [this message]
2021-04-27 14:50 ` Theodore Ts'o
2021-04-27 15:06 ` Gabriel Krisman Bertazi
2021-04-28 14:12 ` Theodore Ts'o
2021-04-28 18:58 ` Gabriel Krisman Bertazi
[not found] ` <7caab939-2800-0cc2-7b65-345af3fce73d@collabora.com>
2021-05-11 4:35 ` Christoph Hellwig
2021-05-20 20:19 ` Shreeya Patel
2021-06-03 0:07 ` Gabriel Krisman Bertazi
2021-06-16 4:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d85255-d23e-7016-7fb5-7ab0a6b4b39f@collabora.com \
--to=shreeya.patel@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=andre.almeida@collabora.com \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=ebiggers@google.com \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).