From: Ivan Mikhaylov <i.mikhaylov@yadro.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v13 1/2] dt-bindings: proximity: provide vcnl3020 device tree binding document
Date: Sat, 9 May 2020 13:38:46 +0300 [thread overview]
Message-ID: <61e9c83b910b3df44291a49b5587b772d4145036.camel@yadro.com> (raw)
In-Reply-To: <20200508155050.0000008e@Huawei.com>
On Fri, 2020-05-08 at 15:51 +0100, Jonathan Cameron wrote:
> On Thu, 7 May 2020 16:25:59 +0300
> Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:
>
> > Mostly standard i2c driver with some additional led-current option
> > for vcnl3020.
> >
> > Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
> > ---
> > .../iio/proximity/vishay,vcnl3020.yaml | 65 +++++++++++++++++++
> > 1 file changed, 65 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> > b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> > new file mode 100644
> > index 000000000000..408dee17cdf5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/proximity/vishay,vcnl3020.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Integrated Proximity Sensor With Infrared Emitter
> > +
> > +maintainers:
> > + - Ivan Mikhaylov <i.mikhaylov@yadro.com>
> > +
> > +description: |
> > + The VCNL3020 is a fully integrated proximity sensor. Fully integrated
> > means
> > + that the infrared emitter is included in the package. It has 16-bit
> > + resolution. It includes a signal processing IC and features standard I2C
> > + communication interface. It features an interrupt function.
> > +
> > + Specifications about the devices can be found at:
> > + https://www.vishay.com/docs/84150/vcnl3020.pdf
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - vishay,vcnl3020
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + vdd-supply:
> > + description: Regulator that provides power to the sensor
> > +
> > + vddio-supply:
> > + description: Regulator that provides power to the bus
> > +
> > + vishay,led-current-microamp:
> > + description:
> > + IR LED current value with valid Range = 0 to 20d. e.g. 0 = 0 mA,
> > + 1 = 10 mA, 20 = 200 mA. LED Current is limited to 200 mA for values
> > + higher than decimal 20. The drive current for the LED used in
> > proximity
> > + sensing.
>
> This text is really confusing. Just let the enum speak for itself and leave
> text as
> something short like
>
> "The driver current for the LED used in proximity sensing. "
>
> Units and values are clear already.
>
Jonathan, just to double check, for preventing further problems with
misunderstanding, is that what you want?
vishay,led-current-microamp:
description:
The driver current for the LED used in proximity sensing.
enum: [0..200000] <- just for shortening
default: 20000
Thanks.
next prev parent reply other threads:[~2020-05-09 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 13:25 [PATCH v13 0/2] iio: proximity: driver for vcnl3020 Ivan Mikhaylov
2020-05-07 13:25 ` [PATCH v13 1/2] dt-bindings: proximity: provide vcnl3020 device tree binding document Ivan Mikhaylov
2020-05-08 14:51 ` Jonathan Cameron
2020-05-09 10:38 ` Ivan Mikhaylov [this message]
2020-05-09 15:44 ` Jonathan Cameron
2020-05-07 13:26 ` [PATCH v13 2/2] iio: proximity: Add driver support for vcnl3020 proximity sensor Ivan Mikhaylov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e9c83b910b3df44291a49b5587b772d4145036.camel@yadro.com \
--to=i.mikhaylov@yadro.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).