From: skakit@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
mka@chromium.org, Das Srinagesh <gurus@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
kgunda@codeaurora.org,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp
Date: Tue, 28 Sep 2021 18:12:13 +0530 [thread overview]
Message-ID: <61eabd793256583c930c487b9a21c60b@codeaurora.org> (raw)
In-Reply-To: <CAE-0n53rto=_+9qtc0RL0tkDwBkd9HJL26TQV-m6Q8myiNSCVA@mail.gmail.com>
On 2021-09-21 01:07, Stephen Boyd wrote:
> Quoting Satya Priya (2021-09-17 03:45:38)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> index 52638e2..3b3af49 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> @@ -207,6 +207,97 @@
>> };
>> };
>>
>> +&i2c1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "okay";
>> +
>> + pm8008_chip: pm8008@8 {
>> + compatible = "qcom,pm8008";
>> + reg = <0x8>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pm8008_active>;
>> + };
>> +
>> + pm8008_ldo: pm8008@9 {
> [...]
>> +
>> + pm8008_l7: regulator@4600 {
>> + reg = <0x4600>;
>> + regulator-name = "pm8008_l7";
>> + regulator-min-microvolt = <3000000>;
>> + regulator-max-microvolt = <3544000>;
>> + qcom,min-dropout-voltage = <96000>;
>
> Is this headroom? Is it actually configurable or is it merely a
> property
> of the hardware? If it's the latter then it should be in the driver and
> not in the DTS.
>
Yes this is a headroom and its configurable.
>> + };
>> + };
>> + };
>> +};
>> +
>> &qfprom {
>> vcc-supply = <&vreg_l1c_1p8>;
>> };
>> @@ -313,6 +404,18 @@
>>
>> /* PINCTRL - additions to nodes defined in sc7280.dtsi */
>>
>> +&pm8350c_gpios {
>> + pm8008_reset {
>
> Is this a pinctrl node?
>
No.
>> + pm8008_active: pm8008_active {
>
> Please use dashes in node names wherever an underscore goes.
>
Okay.
>> + pins = "gpio4";
>> + function = "normal";
>> + bias-disable;
>> + output-high;
>> + power-source = <0>;
>> + };
>> + };
>> +};
next prev parent reply other threads:[~2021-09-28 12:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 10:45 [PATCH 0/4] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2021-09-17 10:45 ` [PATCH 1/4] dt-bindings: mfd: pm8008: Add pm8008 regulator node Satya Priya
2021-09-17 19:48 ` Rob Herring
2021-09-20 19:32 ` Stephen Boyd
2021-09-28 12:31 ` skakit
2021-09-20 20:40 ` Rob Herring
2021-09-28 12:43 ` skakit
2021-09-17 10:45 ` [PATCH 2/4] regulator: dt-bindings: Add pm8008 regulator bindings Satya Priya
2021-09-17 15:48 ` Mark Brown
2021-09-28 12:44 ` skakit
2021-09-17 10:45 ` [PATCH 3/4] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2021-09-17 15:38 ` Mark Brown
2021-09-28 12:16 ` skakit
2021-09-17 10:45 ` [PATCH 4/4] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp Satya Priya
2021-09-20 19:37 ` Stephen Boyd
2021-09-28 12:42 ` skakit [this message]
2021-09-17 11:01 ` [PATCH 0/4] Add Qualcomm Technologies, Inc. PM8008 regulator driver skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61eabd793256583c930c487b9a21c60b@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).