From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Josef Friedl <josef.friedl@speed.at>,
Sean Wang <sean.wang@mediatek.com>,
Ryder Lee <ryder.lee@mediatek.com>
Subject: Re: Aw: Re: [PATCH 3/3] add driver and MAINTAINERS for poweroff
Date: Wed, 3 Jul 2019 13:54:41 +0200 [thread overview]
Message-ID: <61f579d7-f415-481f-6f34-1534f0805dc1@gmail.com> (raw)
In-Reply-To: <trinity-ca99ab22-eda4-42dd-b6eb-8e4bb5c99165-1562143878858@3c-app-gmx-bs07>
On 03/07/2019 10:51, Frank Wunderlich wrote:
> Hi Mathias
>
> thank you for first look on this. Patchseries is originally from Josef Friedl i got some time ago for getting poweroff working on bananapi r2. There it works and maybe on another devices too.
>
> drivers/rtc/rtc-mt6397.c and drivers/rtc/rtc-mt7622.c look very differently on a diff (you've commented in part 1/3)
>
> maybe code is compatible but i have not the knowledge to compare this...maybe sean (sorry, that i missed you) or ryder can say a word about the compatibility.
>
My fault, I didn't got that right. So you are just improving the code of the RTC
driver. Which is great, but as already said, do this in a separate patch. :)
Regards,
Matthias
>> Fix the commit message. MAINTAINERS get normally send a independent patch.
>> Split patches between RTC and PWRC.
>> If not a new patch it should be stated in the commit message at least.
>
> i will try to split this
>
>>> + * Author: Tianping.Fang <tianping.fang@mediatek.com>
>>> + * Sean Wang <sean.wang@mediatek.com>
>>
>> You are the author of this file, aren't you?
>
> no, afaik these is code taken from rtc-mt6397.c and put in a separate header-file to use it in multiple c-files.
>
> sidenote on encoding/word-wrap. i use only "git sendemail" which afaik calls sendmail (no other mta like thunderbird or similar) on ubuntu 18.4....curently have no idea how to fix this...have searched before, but not yet found anything. if you have an idea please give me a hint.
>
> regards Frank
>
prev parent reply other threads:[~2019-07-03 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 9:40 [PATCH 0/3] implement poweroff for mt6323/6397 Frank Wunderlich
2019-07-02 9:40 ` [PATCH 1/3] add doc and MAINTAINERS for poweroff Frank Wunderlich
2019-07-02 10:00 ` Ryder Lee
2019-07-02 13:23 ` Andrew Lunn
2019-07-03 7:22 ` Matthias Brugger
2019-07-02 9:40 ` [PATCH 2/3] add dts " Frank Wunderlich
2019-07-02 9:40 ` [PATCH 3/3] add driver and MAINTAINERS " Frank Wunderlich
2019-07-03 7:26 ` Matthias Brugger
2019-07-03 8:51 ` Aw: " Frank Wunderlich
2019-07-03 11:54 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61f579d7-f415-481f-6f34-1534f0805dc1@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=josef.friedl@speed.at \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).