From: Sinan Kaya <okaya@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] ACPI: Allow PCI to be disabled for reboot
Date: Tue, 11 Dec 2018 17:00:22 -0500 [thread overview]
Message-ID: <620b7955-de9c-a273-bf1c-5521834e16a6@kernel.org> (raw)
In-Reply-To: <CAJZ5v0gsq4-pzMrqrKuiUysXbnjc5AfVnY3=2OxQRZPsma=ZMA@mail.gmail.com>
On 12/11/2018 4:49 PM, Rafael J. Wysocki wrote:
>> I struggled between break and return. Existing code seems to return on failure
>> when bus0 is NULL. I assumed it would be more logical to return as someone could
>> put some code after here that assumes everything is in order.
> Well, there's no such code ATM, so there's no practical difference
> between the two and you don't really need the #else branch at all, do
> you?
>
OK. I'll go with break.
prev parent reply other threads:[~2018-12-11 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 21:46 [PATCH v2 1/3] ACPI: Allow PCI to be disabled for reboot Sinan Kaya
2018-12-08 21:46 ` [PATCH v2 2/3] ACPI / OSL: Allow PCI to be disabled Sinan Kaya
2018-12-08 21:46 ` [PATCH v2 3/3] PCI/ACPI: allow ACPI to be built without PCI support Sinan Kaya
2018-12-09 6:20 ` Andy Shevchenko
2018-12-09 16:03 ` Sinan Kaya
2018-12-11 10:12 ` [PATCH v2 1/3] ACPI: Allow PCI to be disabled for reboot Rafael J. Wysocki
2018-12-11 16:54 ` Sinan Kaya
2018-12-11 21:49 ` Rafael J. Wysocki
2018-12-11 22:00 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=620b7955-de9c-a273-bf1c-5521834e16a6@kernel.org \
--to=okaya@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).