From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBB5C433EF for ; Thu, 14 Apr 2022 20:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346657AbiDNUsI (ORCPT ); Thu, 14 Apr 2022 16:48:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344952AbiDNUsD (ORCPT ); Thu, 14 Apr 2022 16:48:03 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEB31ED9FE for ; Thu, 14 Apr 2022 13:45:37 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nf6L4-0005dK-5A; Thu, 14 Apr 2022 22:45:14 +0200 Message-ID: <6221c3d0da08ef15f572593d67fd0e9c7ba03ab0.camel@pengutronix.de> Subject: Re: [PATCH v2 0/7] Add the iMX8MP PCIe support From: Lucas Stach To: Richard Zhu , p.zabel@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org, shawnguo@kernel.org, vkoul@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Date: Thu, 14 Apr 2022 22:45:11 +0200 In-Reply-To: <1646644054-24421-1-git-send-email-hongxing.zhu@nxp.com> References: <1646644054-24421-1-git-send-email-hongxing.zhu@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, I didn't get around to see what's wrong with the PCIe on my EVK, so I wasn't able to do any reworks to the series. As I will be on vacation from tomorrow until Apr. 25th, I'll just leave some more comments on this series for your consideration. Regards, Lucas Am Montag, dem 07.03.2022 um 17:07 +0800 schrieb Richard Zhu: > Based on the i.MX8MP GPC and blk-ctrl patch-set[1] issued by Lucas and the > following commits. > - one codes refine patch-set[5]. > - two Fixes[2],[3]. > - one binding commit[4]. > - some dts changes in Shawn's git if you want to test PCIe on i.MX8MM EVK. > b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on imx8mm evk board > aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support > cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support > > Sorry about that there may be some conflictions when do the codes merge. > I'm waiting for the ack now, and will re-base them in a proper sequence later. > > This series patches add the i.MX8MP PCIe support and tested on i.MX8MM EVK and > i.MX8MP EVk boards. The PCIe NVME works fine on both boards. > > - i.MX8MP PCIe PHY has two resets refer to the i.MX8MM PCIe PHY. > Add one more PHY reset for i.MX8MP PCIe PHY accordingly. > - Add the i.MX8MP PCIe PHY support in the i.MX8M PCIe PHY driver. > And share as much as possible codes with i.MX8MM PCIe PHY. > - Add the i.MX8MP PCIe support in binding document, DTS files, and PCIe > driver. > > Main changes v1-->v2: > - It's my fault forget including Vinod, re-send v2 after include Vinod > and linux-phy@lists.infradead.org. > - List the basements of this patch-set. The branch, codes changes and so on. > - Clean up some useless register and bit definitions in #3 patch. > > [1]https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220228201731.3330192-1-l.stach@pengutronix.de/ > [2]https://patchwork.ozlabs.org/project/linux-pci/patch/1646289275-17813-1-git-send-email-hongxing.zhu@nxp.com/ > [3]https://patchwork.ozlabs.org/project/linux-pci/patch/1645672013-8949-1-git-send-email-hongxing.zhu@nxp.com/ > [4]https://patchwork.ozlabs.org/project/linux-pci/patch/1646293805-18248-1-git-send-email-hongxing.zhu@nxp.com/ > [5]https://patchwork.ozlabs.org/project/linux-pci/cover/1645760667-10510-1-git-send-email-hongxing.zhu@nxp.com/ > > NOTE: > Based git > Based branch > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 + > Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 4 +- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 55 ++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 46 ++++++++++++++++++- > drivers/pci/controller/dwc/pci-imx6.c | 19 +++++++- > drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 205 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------- > drivers/reset/reset-imx7.c | 1 + > 7 files changed, 286 insertions(+), 45 deletions(-) > > [PATCH v2 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support > [PATCH v2 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding > [PATCH v2 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY > [PATCH v2 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible > [PATCH v2 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support > [PATCH v2 6/7] arm64: dts: imx8mp-evk: Add PCIe support > [PATCH v2 7/7] PCI: imx6: Add the iMX8MP PCIe support