From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbcGMSwF (ORCPT ); Wed, 13 Jul 2016 14:52:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44785 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbcGMSvz (ORCPT ); Wed, 13 Jul 2016 14:51:55 -0400 Subject: Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask To: "Wei, Jiangang" References: <1467862098-2374-1-git-send-email-weijg.fnst@cn.fujitsu.com> <20160707152510.GJ17766@localhost.localdomain> <1468396427.2020.14.camel@localhost> Cc: "linux-kernel@vger.kernel.org" , "david.vrabel@citrix.com" , "tglx@linutronix.de" , "jgross@suse.com" , "konrad.wilk@oracle.com" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "xen-devel@lists.xenproject.org" From: Boris Ostrovsky Message-ID: <6227c76d-eb29-fa28-98cc-a3fcf9680d0c@oracle.com> Date: Wed, 13 Jul 2016 14:51:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1468396427.2020.14.camel@localhost> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2016 03:56 AM, Wei, Jiangang wrote: > On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote: >> On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote: >>> On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote: >>>> verify_local_APIC() had been removed by >>>> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), >>>> so apic_id_mask isn't used by it. >> Is anyone actually using this field? It looks like 4399c03c6780 removed >> the only user. > Indeed, the field is useless. > Maybe we can remove this field from the struct apic . > what's your opinion? Since noone seems to be using those I think it can be removed. -boris > > Thanks, > wei >> -boris >> >> >>> CC-ing the proper maintainers. >>>> Signed-off-by: Wei Jiangang >>>> --- >>>> arch/x86/xen/apic.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c >>>> index db52a7fafcc2..9cbb1f48381b 100644 >>>> --- a/arch/x86/xen/apic.c >>>> +++ b/arch/x86/xen/apic.c >>>> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = { >>>> >>>> .get_apic_id = xen_get_apic_id, >>>> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */ >>>> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */ >>>> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */ >>>> >>>> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and, >>>> >>>> -- >>>> 1.9.3 >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Xen-devel mailing list >>>> Xen-devel@lists.xen.org >>>> https://lists.xen.org/xen-devel >> >> >> > >