From: Jens Axboe <axboe@kernel.dk>
To: Parshuram Thombare <pthombar@cadence.com>,
tj@kernel.org, jbacik@fb.com, michaelcallahan@fb.com,
snitzer@redhat.com, osandov@fb.com, keith.busch@intel.com,
ming.lei@redhat.com, shli@fb.com, dennisszhou@gmail.com,
linux-kernel@vger.kernel.org
Cc: adouglas@cadence.com, jank@cadence.com, rafalc@cadence.com
Subject: Re: [PATCH 1/2] block: add bi_crypto_ctx variable in struct bio
Date: Tue, 11 Dec 2018 06:37:04 -0700 [thread overview]
Message-ID: <62281c61-de73-a0a3-2ea2-eeea81778eea@kernel.dk> (raw)
In-Reply-To: <20181211095001.GA32573@lvlogina.cadence.com>
On 12/11/18 2:50 AM, Parshuram Thombare wrote:
> Add variable 'void *bi_crypt_ctx' in 'struct bio'. This will
> be used to associate bio with crypto configuration of controller
> supporting real time / inline encryption/decryption.
>
> Signed-off-by: Parshuram Thombare <pthombar@cadence.com>
> ---
> include/linux/blk_types.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 1dcf652..bd77603 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -188,6 +188,10 @@ struct bio {
> #endif
> };
>
> +#ifdef CONFIG_BLK_DEV_HW_RT_ENCRYPTION
> + void *bi_crypto_ctx;
> +#endif
> +
> unsigned short bi_vcnt; /* how many bio_vec's */
>
> /*
Pretty sure I mentioned this last time, but in case I didn't, don't
add bio members for random drivers. Can you imagine how huge
this thing would be if we allowed that?
If you need per-io storage, put it in the payload for the blk-mq
request. That way you are only bloating your own IO related data
structures, not everyones.
--
Jens Axboe
next prev parent reply other threads:[~2018-12-11 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:50 [PATCH 1/2] block: add bi_crypto_ctx variable in struct bio Parshuram Thombare
2018-12-11 13:37 ` Jens Axboe [this message]
2018-12-12 5:34 ` Parshuram Raju Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62281c61-de73-a0a3-2ea2-eeea81778eea@kernel.dk \
--to=axboe@kernel.dk \
--cc=adouglas@cadence.com \
--cc=dennisszhou@gmail.com \
--cc=jank@cadence.com \
--cc=jbacik@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelcallahan@fb.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=pthombar@cadence.com \
--cc=rafalc@cadence.com \
--cc=shli@fb.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).