From: CGEL <cgel.zte@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: bsingharora@gmail.com, akpm@linux-foundation.org,
yang.yang29@zte.com.cn, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] delayacct: track delays from ksm cow
Date: Thu, 17 Mar 2022 09:48:49 +0000 [thread overview]
Message-ID: <62330402.1c69fb81.d2ba6.0538@mx.google.com> (raw)
In-Reply-To: <4e76476b-1da0-09c5-7dc4-0b2db796a549@redhat.com>
On Thu, Mar 17, 2022 at 09:17:13AM +0100, David Hildenbrand wrote:
> On 17.03.22 03:03, CGEL wrote:
> > On Wed, Mar 16, 2022 at 03:56:23PM +0100, David Hildenbrand wrote:
> >> On 16.03.22 14:34, cgel.zte@gmail.com wrote:
> >>> From: Yang Yang <yang.yang29@zte.com.cn>
> >>>
> >>> Delay accounting does not track the delay of ksm cow. When tasks
> >>> have many ksm pages, it may spend a amount of time waiting for ksm
> >>> cow.
> >>>
> >>> To get the impact of tasks in ksm cow, measure the delay when ksm
> >>> cow happens. This could help users to decide whether to user ksm
> >>> or not.
> >>>
> >>> Also update tools/accounting/getdelays.c:
> >>>
> >>> / # ./getdelays -dl -p 231
> >>> print delayacct stats ON
> >>> listen forever
> >>> PID 231
> >>>
> >>> CPU count real total virtual total delay total delay average
> >>> 6247 1859000000 2154070021 1674255063 0.268ms
> >>> IO count delay total delay average
> >>> 0 0 0ms
> >>> SWAP count delay total delay average
> >>> 0 0 0ms
> >>> RECLAIM count delay total delay average
> >>> 0 0 0ms
> >>> THRASHING count delay total delay average
> >>> 0 0 0ms
> >>> KSM count delay total delay average
> >>> 3635 271567604 0ms
> >>>
> >>
> >> TBH I'm not sure how particularly helpful this is and if we want this.
> >>
> > Thanks for replying.
> >
> > Users may use ksm by calling madvise(, , MADV_MERGEABLE) when they want
> > save memory, it's a tradeoff by suffering delay on ksm cow. Users can
> > get to know how much memory ksm saved by reading
> > /sys/kernel/mm/ksm/pages_sharing, but they don't know what the costs of
> > ksm cow delay, and this is important of some delay sensitive tasks. If
> > users know both saved memory and ksm cow delay, they could better use
> > madvise(, , MADV_MERGEABLE).
>
> But that happens after the effects, no?
>
> IOW a user already called madvise(, , MADV_MERGEABLE) and then gets the
> results.
>
Image user are developing or porting their applications on experiment
machine, they could takes those benchmark as feedback to adjust whether
to use madvise(, , MADV_MERGEABLE) or it's range.
> So how is this interface useful except for somebody writing an
> application and simply being able to benchmark it with vs. without
> MADV_MERGEABLE?
>
> --
> Thanks,
>
> David / dhildenb
next prev parent reply other threads:[~2022-03-17 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 13:34 [PATCH] delayacct: track delays from ksm cow cgel.zte
2022-03-16 14:56 ` David Hildenbrand
2022-03-17 2:03 ` CGEL
2022-03-17 8:17 ` David Hildenbrand
2022-03-17 9:48 ` CGEL [this message]
2022-03-17 10:05 ` David Hildenbrand
2022-03-18 1:41 ` CGEL
2022-03-18 8:24 ` David Hildenbrand
2022-03-20 6:13 ` CGEL
2022-03-21 15:45 ` David Hildenbrand
2022-03-22 3:12 ` CGEL
2022-03-22 7:55 ` David Hildenbrand
2022-03-22 9:09 ` CGEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62330402.1c69fb81.d2ba6.0538@mx.google.com \
--to=cgel.zte@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).