From: Rong Chen <rong.a.chen@intel.com>
To: John Hubbard <jhubbard@nvidia.com>,
kernel test robot <lkp@intel.com>, Yang Shi <shy828301@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [kbuild-all] Re: [PATCH] mm: gup: remove FOLL_SPLIT
Date: Fri, 9 Apr 2021 16:44:21 +0800 [thread overview]
Message-ID: <6236d7d0-7e81-c88a-e019-12707e574274@intel.com> (raw)
In-Reply-To: <ffa96851-ce93-12b4-70ca-594f00fa3c2b@nvidia.com>
Hi John,
On 3/30/21 3:08 PM, John Hubbard wrote:
> On 3/29/21 11:24 PM, kernel test robot wrote:
>> Hi Yang,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on hnaz-linux-mm/master]
>>
>> url:
>> https://github.com/0day-ci/linux/commits/Yang-Shi/mm-gup-remove-FOLL_SPLIT/20210330-034042
>> base: https://github.com/hnaz/linux-mm master
>> config: s390-randconfig-r032-20210330 (attached as .config)
>> compiler: s390-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> #
>> https://github.com/0day-ci/linux/commit/c8563a636718f98af86a3965d94e25b8f2cf2354
>> git remote add linux-review https://github.com/0day-ci/linux
>> git fetch --no-tags linux-review
>> Yang-Shi/mm-gup-remove-FOLL_SPLIT/20210330-034042
>> git checkout c8563a636718f98af86a3965d94e25b8f2cf2354
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
>> make.cross ARCH=s390
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> arch/s390/mm/gmap.c: In function 'thp_split_mm':
>>>> arch/s390/mm/gmap.c:2498:27: error: 'FOLL_SPLIT' undeclared (first
>>>> use in this function); did you mean 'FOLL_PIN'?
>> 2498 | follow_page(vma, addr, FOLL_SPLIT);
>> | ^~~~~~~~~~
>> | FOLL_PIN
>> arch/s390/mm/gmap.c:2498:27: note: each undeclared identifier is
>> reported only once for each function it appears in
>>
>>
>> vim +2498 arch/s390/mm/gmap.c
>
> There appears to be an imperfection in this 0day testing system,
> because (just as the patch
> says), commit ba925fa35057a062ac98c3e8138b013ce4ce351c ("s390/gmap:
> improve THP splitting"),
> July 29, 2020, removes the above use of FOLL_SPLIT.
>
> And "git grep", just to be sure, shows it is not there in today's
> linux.git. So I guess the
> https://github.com/0day-ci/linux repo needs a better way to stay in sync?
Sorry for the delay, indeed, it's a issue from 0day-CI, we'll update
linux-mm in the system.
Best Regards,
Rong Chen
next prev parent reply other threads:[~2021-04-09 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 19:38 [PATCH] mm: gup: remove FOLL_SPLIT Yang Shi
2021-03-30 6:24 ` kernel test robot
2021-03-30 7:08 ` John Hubbard
2021-04-09 8:44 ` Rong Chen [this message]
2021-03-30 7:08 ` John Hubbard
2021-03-30 16:34 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6236d7d0-7e81-c88a-e019-12707e574274@intel.com \
--to=rong.a.chen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).