From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933750AbcKGTHS (ORCPT ); Mon, 7 Nov 2016 14:07:18 -0500 Received: from mail-db5eur01on0136.outbound.protection.outlook.com ([104.47.2.136]:32864 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932923AbcKGTHO (ORCPT ); Mon, 7 Nov 2016 14:07:14 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dsafonov@virtuozzo.com; Subject: Re: [RFC] proc: don't show kernel-internal mnt_id in fdinfo (if possible) To: "Eric W. Biederman" References: <20161107160635.21556-1-dsafonov@virtuozzo.com> <87pom743ty.fsf@xmission.com> CC: , <0x7f454c46@gmail.com>, Al Viro , Andrey Vagin , Rob Landley From: Dmitry Safonov Message-ID: <623d3267-2189-2f33-1805-2691769b87a7@virtuozzo.com> Date: Mon, 7 Nov 2016 20:30:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87pom743ty.fsf@xmission.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM5PR0101CA0012.eurprd01.prod.exchangelabs.com (10.169.240.22) To VI1PR0801MB1744.eurprd08.prod.outlook.com (10.168.67.22) X-MS-Office365-Filtering-Correlation-Id: 041226fe-bfd1-40e4-e5ce-08d4073434f1 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1744;2:3ARa/6I4yFEVbLWf7uO2Oj6FLGFeHKLiC6E19h0k4/+CK8QvX3ZUksHLzlWpSVLHfrJ6l+fCZBxbMHNrERWmCOlsrjHlouOEZGjxeMlooY/bCVXFHO4ANkZl4sEeJ70hreO3AMmOx+O5oObvf6SPARBw4NV3KsZaBZQYfTNPBCKSCPa4hFp0yhaBKzkpli7PLf5LI8W4z3HmHwhs9y+2zw==;3:Zry3VY6YLZqqdOMDkxF//sBL58pX8N5q2GKfee7CP4Z76tZNBj4PfVd9MOnm6IuZxh4yc45wARdbZXSDPb6qhc2bUdTzbRd5wd0/4APrhDD72jRc6P6W5DnTEiUvgyTIH5IVpe256PSzGXmSMvhFLQ==;25:VOzI6fZKlNBS1qIpSRtDBefvPCnWuNBAFoJEOfczB1PzYoAk8miqSql+hGTK6NoW18b85JWEwpwI7bH6dxz8pg5Wsfk2Lt6F7WAxzYVppUs+Qf4iC9/ushn8wBSMvWlaQ+mbHP5NKjxQOOX+PIk3xu5QEWz/vpcOweBTlRoTnyMehonEsbCVS4l2NgL4HVyJZ7nAknpgeRzn8KUU71I7FsyCBJTSrIUfBxkfOiZutADShd48xHInidYiiQNKio7yFfb1gbwM+FOY4qebkNHEOOJeBGKoR2ahnjFjahmmuQmBj+SFEa476VQJvOX38LkjmOvPI6IG5y0XGEF1o7shZ2skuEfLN4NJD4cE7i2SpdrUrObL/eKgTE+T9R15XMhGm/D0q4Gf5bE6msyRxMLbmbk0wT02w8lb5W9vCSWvZk4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1744; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1744;31:sQVJt60Pz1mVBqdQDdDiCF+ZHQm371e5Nw1gpBbjusYaX+tBTWYCG3959cFpHMfq4t0A+dyntXIzSQQ4RXF1dD+h14vXOaIr8Gj+DSrlcSBPjwgxjTdANdAEpU0Eq0iFWC+ekdFRQoQ9kJF2ZRiDzCtfgjNrEeN5qvsn087xngwGR1oIqthG44a8md5KMiy3YDTNSgENt41Al82tDhwG3WvyFaYEPCNa6rgjHQA4D+nBMCRqpCZP81K6BBbd/Ms5;20:itoF1Hqk0KJuRAnWHNcAl3bOl1W/kytxeGlH9CC3HCTVfxxB5hJKMF/PsDZ4RA8JAcNUdkUzTpHlUEgtVyrx7FOLB5tDhfD1/hvBTP3dQLHQRX/9aoFInuoCbdwCryQHVOmksn2n6fDO9PKYO6xqdgQFPakidU1df112KEXDHyPkL9D/6F3dWtKh8i1XD8+hIxCEtbn+LYu571v/e6hlpV7SLHR9uF0z+w78zjS/fyz1x+Hs0u2JkMcNAcYrVM72 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6042046)(6043046);SRVR:VI1PR0801MB1744;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1744; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1744;4:LBOpaPnVjf76C+VFmYdmczWnGDkF5DR4VQ0MuEbIELLK+F0AUGMpKtyx979vxM00HzL8RZ8WjcRo2c8yITOQla+Yvc73uy8t9XptPR+/mGTQkqIvA0SEWjE8ti8sOTGjTZPFqec6EwZs2vPsGbsdIWjxNj9EO+0SLOY6XRdO1OTvYIQswMDd+fBdhhO2nsk4f3ce6uBgHfNqMOghqdg3nx2k2yB6yFYi7fgBD4aLFO09gFuXq/ERIm8/PJlzj5WAzJ1p+USRGhQ3rs6iifh29XWYV4oRJbtNkNKmGBmhIAYK2VVrQa8cnStZN6V2pe3FBgO6Hm6gIG5zqA4KbpAKdXWXmIqYXodPd4M+qAWL4DQYavC7mHxvm7labarpJq16g4VmSAhjcZZtLVz0I+QzLUtwBJysSUKn1rhZnMc61f/X7BzGBjf3lG0PZ9PG1Yo/ X-Forefront-PRVS: 0119DC3B5E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(24454002)(377454003)(4326007)(105586002)(2906002)(83506001)(42186005)(106356001)(19580395003)(19580405001)(31686004)(68736007)(77096005)(5660300001)(50466002)(3846002)(86362001)(31696002)(110136003)(65826007)(7736002)(7846002)(305945005)(81156014)(81166006)(6666003)(2950100002)(6916009)(92566002)(8676002)(64126003)(6116002)(66066001)(101416001)(50986999)(230700001)(23746002)(586003)(54356999)(76176999)(4001350100001)(97736004)(36756003)(189998001)(65956001)(47776003)(33646002)(65806001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1744;H:[10.30.26.154];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0801MB1744;23:o8w2ObFIbHzy1UkybPvDkrXcfrI+bi5d3/q?= =?Windows-1252?Q?0BYQskteirtxF2+WPU18x0jY2VzNJ4FwaUatltnWQ1nQeqpXKeJRK1nb?= =?Windows-1252?Q?nZYZHjxflod8GuRNzsTCGNF2VgaRb3xUADvRLAnwvvmBHc58Ll4wRMrn?= =?Windows-1252?Q?fq6BeaRvMxf1iRHyAHw882qMekE6ShSIF1KbY76fxsFgX7Re2QGJZ1KW?= =?Windows-1252?Q?x0GbaIjMJumKa0XkvLWBwwJFszHAkcwG2cuDkYpRWGRvv/agGXu2GpiH?= =?Windows-1252?Q?gWga1yqOB7ukENsxxbVdX/d6LpRDaI9o+TNL0SBATj+Igw9Xoh5Y6Gkt?= =?Windows-1252?Q?62z6rW5v0FUQSctxNaHYyveZbYqhAYy9lK74IJURLcN6umCz8OnaYNZ0?= =?Windows-1252?Q?u8Ltglo7TaANtnVns//8zEcydQywdLaPDlh9VQX9ElbS+R7y7q4UltFz?= =?Windows-1252?Q?a03g6o3ixrrhdLmxQrr/NpxB7oOWeK265b/AxEbmjRWtEKWOyeCbgf+o?= =?Windows-1252?Q?KHHaXV4o758qrrA1Bgdv6letOgFrMg7XwgGHoM5+iG5dz3ijM+oJlgqw?= =?Windows-1252?Q?igLwF9feo0vsPwzb1980iOEf950tibqeCzXwfwH29qv2Q9lFCJB/9+WI?= =?Windows-1252?Q?C1lOJ5k/R1sl4Uq9/yoCOrbcI0MsprQYuW4acGM0GFIGio+JxcmQpFE+?= =?Windows-1252?Q?+8hLkySLtgMc++4bi363w3eEvfKhYCMgX5W9/RdRmAeZ9YkBJ7Q/bXFg?= =?Windows-1252?Q?XoMw++YrfitxyUW4NGuX6UvQs5eOsrQXvf0JgAWCA/q+yEzN7tdjEm4O?= =?Windows-1252?Q?OKaA5EqKJbutNtk9Be97Mpg5LdI1GoauGso7RydoMKHlIZ5L7FaG1+rN?= =?Windows-1252?Q?uUUwUX6BGS9zWzDCMUyqaUZh3J2x4AW3wdljz4f+BoR7a2M10qJatig4?= =?Windows-1252?Q?/LyHRWbfJqaIUSJKmFbRhnQIZx99R4RfCLMMznOhVPiBA/2Z4MZ5fFWT?= =?Windows-1252?Q?5dT8KsDXVM4gVnRDx4tJixpwiHlg6yXncdYPtA9lgEZKTXIPL30QM8L3?= =?Windows-1252?Q?Sb7oFtFj3gUyDcoZ7FeisQqXtGqf/xsl5T4aHBUc4U3OHSQetNS90CY1?= =?Windows-1252?Q?mvQWugsSLnyccknU9UwTf6kinAnUpSeNfdF5eQofTYoq47dkFzO6/NyM?= =?Windows-1252?Q?NROXuqd6jqGdTgKVRJm8AuVaoneh/rR5ePEAWD2d9ky+0Uqxp/G9prLj?= =?Windows-1252?Q?fTYxoFllk6y9CCNQcxZG3k8OGbco+drGEmHO6BqQoMjj26OkQ2Bcmifa?= =?Windows-1252?Q?0VCJ7+ABUXcynMp13eEYIU0Pl92XYfXDrFkivUxgkfvZwSjEVq6RL9F1?= =?Windows-1252?Q?s3ZLy1LOXGl4kcYezvNhPUNE3nGwMSnvF/8vwt9NOqK51wJnAzTmDTc4?= =?Windows-1252?Q?dQC9LxlnnlsDcTK9d2cPi?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1744;6:zeCkgLtntTr0D/rGpNZEiVWvm1g1toVC89bYAWcrRGPrYwze6PaH7+fs/f2rh6tw+MZXgdQIJNAKumWPkQZcilttJ5KzUDqkLr+D4UZ7ufeUYe/y75uXWm3/KBqd4geCk1KAHQFUw2EYlbBBLh4V3c1eKrBKKXOZlQCqGiJfTp8FtWdh5ZT/uexBuBQB30VTomk4Wslcc+mqSGETq0i5eQn1ERY6ZpZjp3HYVScS/5yh9jqOdDzH6brlUqdwkGMHVzz6Y6ue5kgRaq6eoyJyotLFfqu6xzLXua65kZ7vr8YL/M12XHvjGgFQLdmdPlFhjgaC5DzjVlci3UlI3132ZA==;5:Br+f136GVLSSmL8Y9rPEZN3T6uy6E14CsFBXoLbT5pE1NHqNqlg4HJ7uVRMfJbSw82W+UhFC1nLhV/CVCBOHJHtrSBMLpjAmubN3rIH6pI9C7q1Gg4UO4kbEn98m/5ieEzplEMJCg14t97Ak8q0OrBN4AzmZIehkNkmEgSbMxMI=;24:JzSLddIdcuMmGjQ3fFS/g5+7bFSjCs49UAx3KXgZYZVBgrZgY6oKTXxA4VzxZ66bohOXsASr5P/LJN9cuF0S+gsiXhY0zse5ZCFmnhraLZs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1744;7:YJdQ2t1Yde36PzX5CO2rKBod/GSqB1Mo7u72XJ59TOG4m8D5oaMzRdB5vwh/Phgi6WVypC2aI1iXvqGYAxCJjpyeFAqWuxF4WCFGZ8L6CVUsmUOvvyVrCum80dcdTMlOJYesaLnddeWJVuHC2ZOvIRXqjKDXra/VHXUEYFYRPplvfwtMygE1z6IK2KpCWRCC8pTPEegGTDZsFv5wYP8rl5ekLstkmVrtXTPa221N1Ls0IM2OOwFaudgUAyi65uhzdCGTrzpj3NPQWnYnCkVWPUkL5Y0l8+bmwi9L0Qe9o6IoBH6KnWzMxIa/Sa4aD7NWz12orQpkV5l109xbzBLxOeCvwMusG9Z2ed3kshwSpVk=;20:WOJF/YR8QnP16w10ME47/sWkMEI4jC0Id9JvuBiYFAqz2i2xY+3dggAN2sLMeHmL0iJ6CJtgvw7aUa0xB6j8fIRqxG9ZD/k7Vu/TxZVaUndynQjQVX1XT9XA8fBoiZikBqO7iQMoNlpdUUZe6KFzR2Lzwoi/o9pRL4n5Mz75HGw= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2016 17:33:36.8049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1744 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2016 08:06 PM, Eric W. Biederman wrote: > Dmitry Safonov writes: > >> Some kernel special fs could be mounted by userspace, let's show >> userspace mnt_id in those cases. > > You are asking the kernel to lie to userspace in the case when > the truth in inconvenient. That seems blantantly wrong. > > In the case of an internal mount you may want to use the device id > of the device the filesystem is mounted on so you can tie all of > the mounts together. That would allow restore and other things > to do something useful. > > That information is available with fstat on a file descriptor so I don't > think we need to export it. But if it is not available I can see > the point of a patch. > > Outright ling to userpsace. No. That is just horrible. > > Nacked-by: "Eric W. Biederman" Ah, ok right, I see your point - then let's just drop the patch. Thanks, Dmitry