* [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster
@ 2018-10-05 19:00 Dmitry Torokhov
2018-10-08 5:55 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2018-10-05 19:00 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar
Cc: Heiko Stuebner, Derek Basehore, Guenter Roeck, linux-pm, linux-kernel
RK3899 has one cluster with 4 small cores, and another one with 2 big
cores, with cores in different clusters having different OPPs and thus
needing separate set of tunables. Let's enable this via
"have_governor_per_policy" platform data.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
v2 changes: commit message updated.
Not tested, but we had a patch unconditionally enabling
CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag in tree we used to ship devices
based on RK3399 platform.
drivers/cpufreq/cpufreq-dt-platdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index fe14c57de6ca..040ec0f711f9 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -78,7 +78,10 @@ static const struct of_device_id whitelist[] __initconst = {
{ .compatible = "rockchip,rk3328", },
{ .compatible = "rockchip,rk3366", },
{ .compatible = "rockchip,rk3368", },
- { .compatible = "rockchip,rk3399", },
+ { .compatible = "rockchip,rk3399",
+ .data = &(struct cpufreq_dt_platform_data)
+ { .have_governor_per_policy = true, },
+ },
{ .compatible = "st-ericsson,u8500", },
{ .compatible = "st-ericsson,u8540", },
--
2.19.0.605.g01d371f741-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster
2018-10-05 19:00 [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster Dmitry Torokhov
@ 2018-10-08 5:55 ` Viresh Kumar
2018-10-16 9:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-10-08 5:55 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Rafael J. Wysocki, Heiko Stuebner, Derek Basehore, Guenter Roeck,
linux-pm, linux-kernel
On 05-10-18, 12:00, Dmitry Torokhov wrote:
> RK3899 has one cluster with 4 small cores, and another one with 2 big
> cores, with cores in different clusters having different OPPs and thus
> needing separate set of tunables. Let's enable this via
> "have_governor_per_policy" platform data.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v2 changes: commit message updated.
>
> Not tested, but we had a patch unconditionally enabling
> CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag in tree we used to ship devices
> based on RK3399 platform.
>
> drivers/cpufreq/cpufreq-dt-platdev.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index fe14c57de6ca..040ec0f711f9 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -78,7 +78,10 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "rockchip,rk3328", },
> { .compatible = "rockchip,rk3366", },
> { .compatible = "rockchip,rk3368", },
> - { .compatible = "rockchip,rk3399", },
> + { .compatible = "rockchip,rk3399",
> + .data = &(struct cpufreq_dt_platform_data)
> + { .have_governor_per_policy = true, },
> + },
>
> { .compatible = "st-ericsson,u8500", },
> { .compatible = "st-ericsson,u8540", },
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster
2018-10-08 5:55 ` Viresh Kumar
@ 2018-10-16 9:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-10-16 9:08 UTC (permalink / raw)
To: Viresh Kumar, Dmitry Torokhov
Cc: Heiko Stuebner, Derek Basehore, Guenter Roeck, linux-pm, linux-kernel
On Monday, October 8, 2018 7:55:47 AM CEST Viresh Kumar wrote:
> On 05-10-18, 12:00, Dmitry Torokhov wrote:
> > RK3899 has one cluster with 4 small cores, and another one with 2 big
> > cores, with cores in different clusters having different OPPs and thus
> > needing separate set of tunables. Let's enable this via
> > "have_governor_per_policy" platform data.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >
> > v2 changes: commit message updated.
> >
> > Not tested, but we had a patch unconditionally enabling
> > CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag in tree we used to ship devices
> > based on RK3399 platform.
> >
> > drivers/cpufreq/cpufreq-dt-platdev.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> > index fe14c57de6ca..040ec0f711f9 100644
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -78,7 +78,10 @@ static const struct of_device_id whitelist[] __initconst = {
> > { .compatible = "rockchip,rk3328", },
> > { .compatible = "rockchip,rk3366", },
> > { .compatible = "rockchip,rk3368", },
> > - { .compatible = "rockchip,rk3399", },
> > + { .compatible = "rockchip,rk3399",
> > + .data = &(struct cpufreq_dt_platform_data)
> > + { .have_governor_per_policy = true, },
> > + },
> >
> > { .compatible = "st-ericsson,u8500", },
> > { .compatible = "st-ericsson,u8540", },
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-16 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 19:00 [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster Dmitry Torokhov
2018-10-08 5:55 ` Viresh Kumar
2018-10-16 9:08 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).