From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Neeli <srinivas.neeli@xilinx.com>,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, srinivas.neeli@amd.com,
neelisrinivas18@gmail.com, krzysztof.kozlowski+dt@linaro.org,
michal.simek@xilinx.com, sgoud@xilinx.com, shubhraj@xilinx.com
Cc: devicetree@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com, git@xilinx.com,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH V9 1/3] dt-bindings: rtc: zynqmp: Add clock information
Date: Sat, 25 Jun 2022 22:38:32 +0200 [thread overview]
Message-ID: <62719859-bfed-6c85-76c9-ede0b75d492e@linaro.org> (raw)
In-Reply-To: <20220624120203.2817457-1-srinivas.neeli@xilinx.com>
On 24/06/2022 14:02, Srinivas Neeli wrote:
> Added clock information and deprecated calibration support.
>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Changes in V9:
> -Updated clock information in clock-names.
> Changes in V8:
> -None
> Changes in V7:
> -None
> Changes in V6:
> -Removed dtc warnings.
> Changes in V5:
> -Removed quotes and _clk suffix from clocknames.
> Changes in V4:
> - Deprecated calibrtion support
> Changes in V3:
> - New patch
> ---
> .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> index bdb72d3ddf2a..9dfe2cc5966a 100644
> --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml
> @@ -23,8 +23,15 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: rtc
> +
> interrupts:
> - minItems: 2
> + maxItems: 2
>
> interrupt-names:
> items:
> @@ -39,6 +46,7 @@ properties:
> minimum: 0x1
> maximum: 0x1FFFFF
> default: 0x198233
> + deprecated: true
>
> required:
> - compatible
> @@ -61,5 +69,7 @@ examples:
> interrupts = <0 26 4>, <0 27 4>;
> interrupt-names = "alarm", "sec";
> calibration = <0x198233>;
> + clock-names = "rtc_clk";
> + clocks = <&rtc_clk>;
Please test your bindings with `make dt_binding_check` before sending.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-25 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 12:02 [PATCH V9 1/3] dt-bindings: rtc: zynqmp: Add clock information Srinivas Neeli
2022-06-24 12:02 ` [PATCH V9 2/3] rtc: zynqmp: Updated calibration value Srinivas Neeli
2022-06-24 12:02 ` [PATCH V9 3/3] rtc: zynqmp: Add calibration set and get support Srinivas Neeli
2022-06-24 17:26 ` [PATCH V9 1/3] dt-bindings: rtc: zynqmp: Add clock information Rob Herring
2022-06-25 20:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62719859-bfed-6c85-76c9-ede0b75d492e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=git@xilinx.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=neelisrinivas18@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sgoud@xilinx.com \
--cc=shubhraj@xilinx.com \
--cc=srinivas.neeli@amd.com \
--cc=srinivas.neeli@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).