From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf list: Hide deprecated events by default
Date: Wed, 16 Oct 2019 08:59:13 +0800 [thread overview]
Message-ID: <627305a7-3aec-037a-1c36-6ca884f35d1d@linux.intel.com> (raw)
In-Reply-To: <20191015091401.GE10951@krava>
On 10/15/2019 5:14 PM, Jiri Olsa wrote:
> On Tue, Oct 15, 2019 at 10:53:57AM +0800, Jin Yao wrote:
>> There are some deprecated events listed by perf list. But we can't remove
>> them from perf list with ease because some old scripts may use them.
>>
>> Deprecated events are old names of renamed events. When an event gets
>> renamed the old name is kept around for some time and marked with
>> Deprecated. The newer Intel event lists in the tree already have these
>> headers.
>>
>> So we need to keep them in the event list, but provide a new option to
>> show them. The new option is "--deprecated".
>>
>> With this patch, the deprecated events are hidden by default but they can
>> be displayed when option "--deprecated" is enabled.
>
> not sure it's wise to hide them, because people will not read man page
> to find --deprecated option, they will rather complain right away ;-)
>
> how about to display them as another topic, like:
>
> pipeline:
> ...
> uncore:
> ...
> deprecated:
> ...
>
> jirka
>
Hi Jiri,
I don't know if we add a new topic "deprecated" in perf list output,
does the old script need to be modified as well?
Say the events are moved to the "deprecated" section, I just guess the
script needs the modification.
That's just my personal guess. :)
Thanks
Jin Yao
next prev parent reply other threads:[~2019-10-16 0:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 2:53 [PATCH] perf list: Hide deprecated events by default Jin Yao
2019-10-15 9:14 ` Jiri Olsa
2019-10-16 0:59 ` Jin, Yao [this message]
2019-10-16 7:27 ` Jiri Olsa
2019-10-16 10:22 ` Jin, Yao
2019-10-16 10:27 ` Jiri Olsa
2019-10-16 10:31 ` Jin, Yao
2019-10-16 18:47 ` Andi Kleen
2019-10-18 14:09 ` Jin, Yao
2019-10-18 14:24 ` Jiri Olsa
2019-10-18 16:04 ` Arnaldo Carvalho de Melo
2019-10-21 23:18 ` [tip: perf/core] " tip-bot2 for Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=627305a7-3aec-037a-1c36-6ca884f35d1d@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).