From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932411AbdKDJFn (ORCPT ); Sat, 4 Nov 2017 05:05:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:48741 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756518AbdKDJFl (ORCPT ); Sat, 4 Nov 2017 05:05:41 -0400 Subject: Re: [PATCH 0/3] Add clock driver for Actions S900 SoC To: Manivannan Sadhasivam Cc: mturquette@baylibre.com, sboyd@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, davem@davemloft.net, mchehab@kernel.org, rdunlap@infradead.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, liuwei@actions-semi.com References: <1509479663-8985-1-git-send-email-manivannan.sadhasivam@linaro.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <62797b3b-a622-48a1-9dc5-3cc2b5c7afd3@suse.de> Date: Sat, 4 Nov 2017 17:05:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509479663-8985-1-git-send-email-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mani, Am 01.11.2017 um 03:54 schrieb Manivannan Sadhasivam: > This series adds clock driver for Actions Semi OWL series > S900 SoC with relevant clock bindings and device tree data. > > This series also addresses the review comments from previous > submission happened last year. > > https://patchwork.kernel.org/patch/9254471/ Interesting - I had searched for any S500/S900 patches before starting to work on this but came up empty on LAKML. It seems you missed at least one review comment from 2016 about the example indentation, so please double-check for anything Stephen already pointed out. > Driver has been validated on Bubblegum-96 board. > > Thanks, > Mani > > Manivannan Sadhasivam (3): > arm64: dts: actions: add s900 clock controller nodes > clk: owl: add clock driver for Actions S900 SoC > Documentation: add Actions S900 clock bindings Please reverse the patch order. Have you checked S500 code whether the S900 vs. common split is correct? Many thanks for your work on this, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)