linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/io: remove old GCC version implementation
@ 2018-10-16 12:33 Christophe Leroy
  2018-10-16 12:49 ` Joakim Tjernlund
  2018-10-19  2:51 ` Michael Ellerman
  0 siblings, 2 replies; 5+ messages in thread
From: Christophe Leroy @ 2018-10-16 12:33 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: linux-kernel, linuxppc-dev

GCC 4.6 is the minimum supported now.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 arch/powerpc/include/asm/io.h | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
index 0a034519957d..3ef40b703c4a 100644
--- a/arch/powerpc/include/asm/io.h
+++ b/arch/powerpc/include/asm/io.h
@@ -111,25 +111,6 @@ extern bool isa_io_special;
 #define IO_SET_SYNC_FLAG()
 #endif
 
-/* gcc 4.0 and older doesn't have 'Z' constraint */
-#if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ == 0)
-#define DEF_MMIO_IN_X(name, size, insn)				\
-static inline u##size name(const volatile u##size __iomem *addr)	\
-{									\
-	u##size ret;							\
-	__asm__ __volatile__("sync;"#insn" %0,0,%1;twi 0,%0,0;isync"	\
-		: "=r" (ret) : "r" (addr), "m" (*addr) : "memory");	\
-	return ret;							\
-}
-
-#define DEF_MMIO_OUT_X(name, size, insn)				\
-static inline void name(volatile u##size __iomem *addr, u##size val)	\
-{									\
-	__asm__ __volatile__("sync;"#insn" %1,0,%2"			\
-		: "=m" (*addr) : "r" (val), "r" (addr) : "memory");	\
-	IO_SET_SYNC_FLAG();						\
-}
-#else /* newer gcc */
 #define DEF_MMIO_IN_X(name, size, insn)				\
 static inline u##size name(const volatile u##size __iomem *addr)	\
 {									\
@@ -146,7 +127,6 @@ static inline void name(volatile u##size __iomem *addr, u##size val)	\
 		: "=Z" (*addr) : "r" (val) : "memory");			\
 	IO_SET_SYNC_FLAG();						\
 }
-#endif
 
 #define DEF_MMIO_IN_D(name, size, insn)				\
 static inline u##size name(const volatile u##size __iomem *addr)	\
-- 
2.13.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/io: remove old GCC version implementation
  2018-10-16 12:33 [PATCH] powerpc/io: remove old GCC version implementation Christophe Leroy
@ 2018-10-16 12:49 ` Joakim Tjernlund
  2018-10-16 13:17   ` Christophe LEROY
  2018-10-17  0:51   ` Michael Ellerman
  2018-10-19  2:51 ` Michael Ellerman
  1 sibling, 2 replies; 5+ messages in thread
From: Joakim Tjernlund @ 2018-10-16 12:49 UTC (permalink / raw)
  To: christophe.leroy, paulus, mpe, benh; +Cc: linuxppc-dev, linux-kernel

On Tue, 2018-10-16 at 12:33 +0000, Christophe Leroy wrote:
> 
> 
> GCC 4.6 is the minimum supported now.

Ouch, from kernel 4.19 or earlier even ?

 Jocke

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/io: remove old GCC version implementation
  2018-10-16 12:49 ` Joakim Tjernlund
@ 2018-10-16 13:17   ` Christophe LEROY
  2018-10-17  0:51   ` Michael Ellerman
  1 sibling, 0 replies; 5+ messages in thread
From: Christophe LEROY @ 2018-10-16 13:17 UTC (permalink / raw)
  To: Joakim Tjernlund, paulus, mpe, benh; +Cc: linuxppc-dev, linux-kernel



Le 16/10/2018 à 14:49, Joakim Tjernlund a écrit :
> On Tue, 2018-10-16 at 12:33 +0000, Christophe Leroy wrote:
>>
>>
>> GCC 4.6 is the minimum supported now.
> 
> Ouch, from kernel 4.19 or earlier even ?
> 

Don't know, see 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cafa0010

Christophe

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/io: remove old GCC version implementation
  2018-10-16 12:49 ` Joakim Tjernlund
  2018-10-16 13:17   ` Christophe LEROY
@ 2018-10-17  0:51   ` Michael Ellerman
  1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2018-10-17  0:51 UTC (permalink / raw)
  To: Joakim Tjernlund, christophe.leroy, paulus, benh
  Cc: linuxppc-dev, linux-kernel

Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes:

> On Tue, 2018-10-16 at 12:33 +0000, Christophe Leroy wrote:
>> 
>> 
>> GCC 4.6 is the minimum supported now.
>
> Ouch, from kernel 4.19 or earlier even ?

Yes.

Though to be honest we haven't been testing much with compilers older
than that for several years.

If you care about something older please let us know :)

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: powerpc/io: remove old GCC version implementation
  2018-10-16 12:33 [PATCH] powerpc/io: remove old GCC version implementation Christophe Leroy
  2018-10-16 12:49 ` Joakim Tjernlund
@ 2018-10-19  2:51 ` Michael Ellerman
  1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2018-10-19  2:51 UTC (permalink / raw)
  To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras
  Cc: linuxppc-dev, linux-kernel

On Tue, 2018-10-16 at 12:33:40 UTC, Christophe Leroy wrote:
> GCC 4.6 is the minimum supported now.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/a0e102914aa3f619a5bc68a0d33e17

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-10-19  2:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 12:33 [PATCH] powerpc/io: remove old GCC version implementation Christophe Leroy
2018-10-16 12:49 ` Joakim Tjernlund
2018-10-16 13:17   ` Christophe LEROY
2018-10-17  0:51   ` Michael Ellerman
2018-10-19  2:51 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).