From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Qii Wang <qii.wang@mediatek.com>, Wolfram Sang <wsa@the-dreams.de>
Cc: <matthias.bgg@gmail.com>, <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>
Subject: Re: [v2] i2c: mediatek: Move suspend and resume handling to NOIRQ phase
Date: Thu, 3 Dec 2020 10:01:10 +0200 [thread overview]
Message-ID: <629d171a-0e77-3d74-ae23-e6439dcf17b7@ti.com> (raw)
In-Reply-To: <1606958735.25719.29.camel@mhfsdcap03>
On 03/12/2020 03:25, Qii Wang wrote:
> On Wed, 2020-12-02 at 16:35 +0100, Wolfram Sang wrote:
>> Hi,
>>
>>> Some i2c device driver indirectly uses I2C driver when it is now
>>> being suspended. The i2c devices driver is suspended during the
>>> NOIRQ phase and this cannot be changed due to other dependencies.
>>> Therefore, we also need to move the suspend handling for the I2C
>>> controller driver to the NOIRQ phase as well.
>>>
>>> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
>>
>> Is this a bugfix and should go into 5.10? Or can it wait for 5.11?
>>
>
> Yes, Can you help to apply it into 5.10? Thanks
To be honest if you still do have any i2c device which accessing i2c buss after _noirq
stage and your driver does not implement .master_xfer_atomic() - you definitely have a bigger problem.
So adding IRQF_NO_SUSPEND sound like a hack and probably works just by luck.
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-12-03 8:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 12:17 [v2] i2c: mediatek: Move suspend and resume handling to NOIRQ phase qii.wang
2020-12-02 15:35 ` Wolfram Sang
2020-12-03 1:25 ` Qii Wang
2020-12-03 8:01 ` Grygorii Strashko [this message]
2020-12-07 7:33 ` Qii Wang
2020-12-07 16:35 ` Grygorii Strashko
2020-12-10 1:56 ` Qii Wang
2020-12-10 13:03 ` Grygorii Strashko
2020-12-14 8:48 ` Qii Wang
2020-12-14 20:08 ` Grygorii Strashko
2020-12-15 13:08 ` Qii Wang
2020-12-23 6:31 ` Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=629d171a-0e77-3d74-ae23-e6439dcf17b7@ti.com \
--to=grygorii.strashko@ti.com \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).