From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Nava kishore Manne <nava.manne@xilinx.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, rajanv@xilinx.com, jollys@xilinx.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 2/3] dt-bindings: fpga: Add bindings for ZynqMP nvmem driver
Date: Sun, 16 Sep 2018 15:10:33 +0100 [thread overview]
Message-ID: <62a85f77-ee9d-e6fa-1356-9b68f65882c6@linaro.org> (raw)
In-Reply-To: <1536054754-3119-3-git-send-email-nava.manne@xilinx.com>
Hi Rob,
Do you have any comments on the bindings side of it.
I would like to queue this for next release..
On 04/09/18 10:52, Nava kishore Manne wrote:
> Add documentation to describe Xilinx ZynqMP nvmem driver
> bindings.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> ---
> Changes for v2:
> -Moved nvmem_firmware node as a child to
> firwmare node.
>
> .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> index 1b431d9..4b95fcc 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> @@ -17,6 +17,19 @@ Required properties:
> - "smc" : SMC #0, following the SMCCC
> - "hvc" : HVC #0, following the SMCCC
>
> +--------------------------------------------------------------------------
> += Zynq UltraScale+ MPSoC nvmem firmware driver binding =
> +--------------------------------------------------------------------------
> +The nvmem_firmware node provides access to the hardware related data
> +like soc revision, IDCODE... etc, By using the firmware interface.
> +
> +Required properties:
> +- compatible: should be "xlnx,zynqmp-nvmem-fw"
> +
> += Data cells =
> +Are child nodes of silicon id, bindings of which as described in
> +bindings/nvmem/nvmem.txt
> +
> -------
> Example
> -------
> @@ -25,5 +38,27 @@ firmware {
> zynqmp_firmware: zynqmp-firmware {
> compatible = "xlnx,zynqmp-firmware";
> method = "smc";
> + nvmem_firmware {
> + compatible = "xlnx,zynqmp-nvmem-fw";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + /* Data cells */
> + soc_revision: soc_revision {
> + reg = <0x0 0x4>;
> + };
> + };
> };
> };
> +
> += Data consumers =
> +Are device nodes which consume nvmem data cells.
> +
> +For example:
> +
> + pcap {
> + ...
> + nvmem-cells = <&soc_revision>;
> + nvmem-cell-names = "soc_revision";
> + };
> +
>
Thanks,
srni
next prev parent reply other threads:[~2018-09-16 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 9:52 [RFC PATCH v2 0/3] Add nvmem driver support for ZynqMP Nava kishore Manne
2018-09-04 9:52 ` [RFC PATCH v2 1/3] fairmware: xilinx: Add zynqmp_pm_get_chipid() API Nava kishore Manne
2018-09-04 9:52 ` [RFC PATCH v2 2/3] dt-bindings: fpga: Add bindings for ZynqMP nvmem driver Nava kishore Manne
2018-09-16 14:10 ` Srinivas Kandagatla [this message]
2018-09-04 9:52 ` [RFC PATCH v2 3/3] nvmem: zynqmp: Added zynqmp nvmem firmware driver Nava kishore Manne
2018-09-16 14:10 ` Srinivas Kandagatla
2018-09-17 3:14 ` Nava kishore Manne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62a85f77-ee9d-e6fa-1356-9b68f65882c6@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jollys@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).