From: Colin Ian King <colin.king@canonical.com>
To: Jens Axboe <axboe@kernel.dk>,
Dan Schatzberg <schatzberg.dan@gmail.com>,
linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call
Date: Thu, 18 Mar 2021 20:24:57 +0000 [thread overview]
Message-ID: <62cd71bc-86e1-412d-b2b9-716c0f8021be@canonical.com> (raw)
In-Reply-To: <13a1d187-4d6d-9e06-b94a-553d872de756@kernel.dk>
On 18/03/2021 20:12, Jens Axboe wrote:
> On 3/18/21 9:16 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The 3rd argument to alloc_workqueue should be the max_active count,
>> however currently it is the lo->lo_number that is intended for the
>> loop%d number. Fix this by adding in the missing max_active count.
>
> Dan, please fold this (or something similar) in when you're redoing the
> series.
>
Appreciate this fix being picked up. Are we going to lose the SoB?
Colin
next prev parent reply other threads:[~2021-03-18 20:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 15:16 [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call Colin King
2021-03-18 19:18 ` Muhammad Usama Anjum
2021-03-18 20:12 ` Jens Axboe
2021-03-18 20:24 ` Colin Ian King [this message]
2021-03-18 20:42 ` Jens Axboe
2021-03-19 9:47 ` Dan Carpenter
2021-03-19 10:03 ` Krzysztof Kozlowski
2021-03-19 13:02 ` Jens Axboe
2021-03-19 9:59 ` Krzysztof Kozlowski
2021-03-19 13:05 ` Jens Axboe
2021-03-19 15:51 ` Dan Schatzberg
2021-03-19 15:54 ` Dan Schatzberg
2021-03-19 15:56 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62cd71bc-86e1-412d-b2b9-716c0f8021be@canonical.com \
--to=colin.king@canonical.com \
--cc=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schatzberg.dan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).