From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AFE2C2D0C0 for ; Thu, 26 Dec 2019 06:05:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AB062071E for ; Thu, 26 Dec 2019 06:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726202AbfLZGF0 (ORCPT ); Thu, 26 Dec 2019 01:05:26 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:45912 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725268AbfLZGFZ (ORCPT ); Thu, 26 Dec 2019 01:05:25 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 04C1E5E571A4F74DE764; Thu, 26 Dec 2019 14:05:21 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Thu, 26 Dec 2019 14:05:12 +0800 Subject: Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'cs_block' To: Chao Yu , , References: <20191224124359.15040-1-yuehaibing@huawei.com> <673efe18-d528-2e9b-6d44-a6a7a22086f3@huawei.com> CC: , From: Yuehaibing Message-ID: <62ce1981-9061-f798-a65d-9599ceceb4b8@huawei.com> Date: Thu, 26 Dec 2019 14:05:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <673efe18-d528-2e9b-6d44-a6a7a22086f3@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/12/26 11:44, Chao Yu wrote: > On 2019/12/24 20:43, YueHaibing wrote: >> fs/f2fs/segment.c: In function fix_curseg_write_pointer: >> fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not used [-Wunused-but-set-variable] >> >> It is never used since commit 362d8a920384 ("f2fs: Check >> write pointer consistency of open zones") , so remove it. > > Thanks for the fix! > > Do you mind merging this patch to original patch? as it's still > pending in dev branch. It's ok for me. > > Thanks, > >> >> Reported-by: Hulk Robot >> Signed-off-by: YueHaibing >> --- >> fs/f2fs/segment.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >> index a951953..72cf257 100644 >> --- a/fs/f2fs/segment.c >> +++ b/fs/f2fs/segment.c >> @@ -4482,14 +4482,13 @@ static int fix_curseg_write_pointer(struct f2fs_sb_info *sbi, int type) >> struct f2fs_dev_info *zbd; >> struct blk_zone zone; >> unsigned int cs_section, wp_segno, wp_blkoff, wp_sector_off; >> - block_t cs_zone_block, wp_block, cs_block; >> + block_t cs_zone_block, wp_block; >> unsigned int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT; >> sector_t zone_sector; >> int err; >> >> cs_section = GET_SEC_FROM_SEG(sbi, cs->segno); >> cs_zone_block = START_BLOCK(sbi, GET_SEG_FROM_SEC(sbi, cs_section)); >> - cs_block = START_BLOCK(sbi, cs->segno) + cs->next_blkoff; >> >> zbd = get_target_zoned_dev(sbi, cs_zone_block); >> if (!zbd) >> > > . >