From: Christian Marangi <ansuelsmth@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v2 01/15] net: dsa: qca8k: make mib autocast feature optional
Date: Tue, 19 Jul 2022 14:29:30 +0200 [thread overview]
Message-ID: <62d6a3ad.1c69fb81.8f261.32f5@mx.google.com> (raw)
In-Reply-To: <20220719122636.rsfkejgampb5kcp2@skbuf>
On Tue, Jul 19, 2022 at 03:26:36PM +0300, Vladimir Oltean wrote:
> On Tue, Jul 19, 2022 at 02:57:11AM +0200, Christian Marangi wrote:
> > Some switch may not support mib autocast feature and require the legacy
> > way of reading the regs directly.
> > Make the mib autocast feature optional and permit to declare support for
> > it using match_data struct.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > drivers/net/dsa/qca/qca8k.c | 11 +++++++----
> > drivers/net/dsa/qca/qca8k.h | 1 +
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/dsa/qca/qca8k.c b/drivers/net/dsa/qca/qca8k.c
> > index 1cbb05b0323f..a57c53ce2f0c 100644
> > --- a/drivers/net/dsa/qca/qca8k.c
> > +++ b/drivers/net/dsa/qca/qca8k.c
> > @@ -2112,12 +2112,12 @@ qca8k_get_ethtool_stats(struct dsa_switch *ds, int port,
> > u32 hi = 0;
> > int ret;
> >
> > - if (priv->mgmt_master &&
> > - qca8k_get_ethtool_stats_eth(ds, port, data) > 0)
> > - return;
> > -
> > match_data = of_device_get_match_data(priv->dev);
>
> I didn't notice at the time that you already call of_device_get_match_data()
> at driver runtime, but please be aware that it is a relatively expensive
> operation (takes raw spinlocks, iterates etc), or at least much more
> expensive than it needs to be. What other drivers do is cache the result
> of this function once in priv->info and just use priv->info, since it
> won't change during the lifetime of the driver.
>
Ok makes sense. Can I make a patch drop the use of
of_device_get_match_data and then apply this on top?
(we use of_device_get_match_data also in other functions)
> >
> > + if (priv->mgmt_master && match_data->autocast_mib &&
> > + match_data->autocast_mib(ds, port, data) > 0)
> > + return;
> > +
> > for (i = 0; i < match_data->mib_count; i++) {
> > mib = &ar8327_mib[i];
> > reg = QCA8K_PORT_MIB_COUNTER(port) + mib->offset;
> > @@ -3260,16 +3260,19 @@ static const struct qca8k_match_data qca8327 = {
> > .id = QCA8K_ID_QCA8327,
> > .reduced_package = true,
> > .mib_count = QCA8K_QCA832X_MIB_COUNT,
> > + .autocast_mib = qca8k_get_ethtool_stats_eth,
>
> I thought you were going to create a dedicated sub-structure for
> function pointers?
>
Sorry... totally forgot this as I was very busy with giving good series.
Will handle this in the next version.
(will be also useful later for the single dsa_switch_ops transition if
we want to put all of them there)
> > };
> >
> > static const struct qca8k_match_data qca8328 = {
> > .id = QCA8K_ID_QCA8327,
> > .mib_count = QCA8K_QCA832X_MIB_COUNT,
> > + .autocast_mib = qca8k_get_ethtool_stats_eth,
> > };
> >
> > static const struct qca8k_match_data qca833x = {
> > .id = QCA8K_ID_QCA8337,
> > .mib_count = QCA8K_QCA833X_MIB_COUNT,
> > + .autocast_mib = qca8k_get_ethtool_stats_eth,
> > };
> >
> > static const struct of_device_id qca8k_of_match[] = {
> > diff --git a/drivers/net/dsa/qca/qca8k.h b/drivers/net/dsa/qca/qca8k.h
> > index ec58d0e80a70..c3df0a56cda4 100644
> > --- a/drivers/net/dsa/qca/qca8k.h
> > +++ b/drivers/net/dsa/qca/qca8k.h
> > @@ -328,6 +328,7 @@ struct qca8k_match_data {
> > u8 id;
> > bool reduced_package;
> > u8 mib_count;
> > + int (*autocast_mib)(struct dsa_switch *ds, int port, u64 *data);
> > };
> >
> > enum {
> > --
> > 2.36.1
> >
>
--
Ansuel
next prev parent reply other threads:[~2022-07-19 13:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 0:57 [net-next PATCH v2 00/15] net: dsa: qca8k: code split for qca8k Christian Marangi
2022-07-19 0:57 ` [net-next PATCH v2 01/15] net: dsa: qca8k: make mib autocast feature optional Christian Marangi
2022-07-19 12:26 ` Vladimir Oltean
2022-07-19 12:29 ` Christian Marangi [this message]
2022-07-19 13:36 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 02/15] net: dsa: qca8k: move mib struct to common code Christian Marangi
2022-07-19 12:36 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 03/15] net: dsa: qca8k: move qca8k read/write/rmw and reg table " Christian Marangi
2022-07-19 12:38 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 03/15] net: dsa: qca8k: move qca8kread/write/rmw " Christian Marangi
2022-07-19 1:00 ` Christian Marangi
2022-07-19 1:30 ` Jakub Kicinski
2022-07-19 1:16 ` Christian Marangi
2022-07-19 13:34 ` Vladimir Oltean
2022-07-19 1:32 ` Jakub Kicinski
2022-07-19 1:17 ` Christian Marangi
2022-07-19 0:57 ` [net-next PATCH v2 04/15] net: dsa: qca8k: move qca8k bulk read/write helper " Christian Marangi
2022-07-19 12:40 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 05/15] net: dsa: qca8k: move fdb/vlan/mib init functions " Christian Marangi
2022-07-19 13:13 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 06/15] net: dsa: qca8k: move port set status/eee/ethtool stats function " Christian Marangi
2022-07-19 13:14 ` Vladimir Oltean
2022-07-19 13:16 ` Christian Marangi
2022-07-19 13:18 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 07/15] net: dsa: qca8k: move bridge functions " Christian Marangi
2022-07-19 13:16 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 08/15] net: dsa: qca8k: move fast age/MTU/port enable/disable " Christian Marangi
2022-07-19 13:22 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 09/15] net: dsa: qca8k: move port FDB function " Christian Marangi
2022-07-19 0:57 ` [net-next PATCH v2 10/15] net: dsa: qca8k: move port MDB functions " Christian Marangi
2022-07-19 0:57 ` [net-next PATCH v2 11/15] net: dsa: qca8k: move port mirror " Christian Marangi
2022-07-19 13:24 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 12/15] net: dsa: qca8k: move port VLAN " Christian Marangi
2022-07-19 13:25 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 13/15] net: dsa: qca8k: move port LAG " Christian Marangi
2022-07-19 13:26 ` Vladimir Oltean
2022-07-19 0:57 ` [net-next PATCH v2 14/15] net: dsa: qca8k: move read_switch_id function " Christian Marangi
2022-07-19 0:57 ` [net-next PATCH v2 15/15] net: dsa: qca8k: drop unnecessary exposed function and make them static Christian Marangi
2022-07-19 13:29 ` Vladimir Oltean
2022-07-19 13:35 ` Christian Marangi
2022-07-19 13:44 ` Vladimir Oltean
2022-07-19 13:47 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d6a3ad.1c69fb81.8f261.32f5@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).