From: dinghao.liu@zju.edu.cn
To: "Tony Lindgren" <tony@atomide.com>
Cc: kjlu@umn.edu, "Kalle Valo" <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Johannes Berg" <johannes.berg@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Maital Hahn" <maitalm@ti.com>,
"Fuqian Huang" <huangfq.daxian@gmail.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] wlcore: fix runtime pm imbalance in wl1271_op_suspend
Date: Thu, 21 May 2020 12:51:57 +0800 (GMT+08:00) [thread overview]
Message-ID: <62e69631.b9cff.1723592e191.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20200520184854.GY37466@atomide.com>
There is a check against ret after out_sleep tag. If wl1271_configure_suspend_ap()
returns an error code, ret will be caught by this check and a warning will be issued.
"Tony Lindgren" <tony@atomide.com>写道：
> * Dinghao Liu <dinghao.liu@zju.edu.cn> [200520 12:58]:
> > When wlcore_hw_interrupt_notify() returns an error code,
> > a pairing runtime PM usage counter decrement is needed to
> > keep the counter balanced.
>
> We should probably keep the warning though, nothing will
> get shown for wl1271_configure_suspend_ap() errors.
>
> Otherwise looks good to me.
>
> Regards,
>
> Tony
next prev parent reply other threads:[~2020-05-21 4:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 12:57 [PATCH] wlcore: fix runtime pm imbalance in wl1271_op_suspend Dinghao Liu
2020-05-20 18:48 ` Tony Lindgren
2020-05-21 4:51 ` dinghao.liu [this message]
2020-05-21 15:59 ` Tony Lindgren
2020-05-29 17:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62e69631.b9cff.1723592e191.Coremail.dinghao.liu@zju.edu.cn \
--to=dinghao.liu@zju.edu.cn \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=huangfq.daxian@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kjlu@umn.edu \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maitalm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).