From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 370FFC4361B for ; Thu, 3 Dec 2020 17:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0819207BD for ; Thu, 3 Dec 2020 17:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728750AbgLCRiG (ORCPT ); Thu, 3 Dec 2020 12:38:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36060 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbgLCRiD (ORCPT ); Thu, 3 Dec 2020 12:38:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607016996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IqCBpFSft+AbjyuMAKdWaJ7NxQe9CDa5oWKrC6azTtM=; b=gHoZ2sP2Zg6KJKAqS7chrj896BeMxH9jD2zQ+tyeTRNGGsRxNnXskqd54+2o0vhQFOJmcU fNGx0daARBMNtJr/oRI9kgKmS+9lD+Bbwi/A50Mz+P/qIpQnqxWK565IeotbNHEbY+O3YR veSLyOzGnSotQH4drB8WgN2KjjIllz0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-5spT0q3jMeWMPbsGDNVGhw-1; Thu, 03 Dec 2020 12:36:34 -0500 X-MC-Unique: 5spT0q3jMeWMPbsGDNVGhw-1 Received: by mail-ed1-f71.google.com with SMTP id c24so1251046edx.2 for ; Thu, 03 Dec 2020 09:36:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IqCBpFSft+AbjyuMAKdWaJ7NxQe9CDa5oWKrC6azTtM=; b=aHLXn4gYcMBSq4DkO60Buvqz+KKRLk5+OGNfovg2pyASSkpKrEVdODTs7vvfZ6oHOt iz+EbwHOcY1UILbFxOvNstGYjt3l0jUrB6X5BtXsr3SF6XsIc21UIJDQ6PmaRLAgur2W DNe9iUywI2uA0lMUdUb6q+UuRjGAqdtGjs7+Gs5ODdGl+IIKlZq+32xc0/pF3Z7L7uoJ u1qILFdyVlQo0YN5ZFRNgdeM4+QYMmb/Wz609W4Vbdwxa0gIMuFdhc81yprXaUnUaHna 1B6ORFNwcaNpOZ+SNM5RZfXPvpFk8HO72yd7pIW9+NrMPYawjrmIMJmMycpiXpqLed06 LO1w== X-Gm-Message-State: AOAM5316S4br1xxZhvE49coM3KyJxyBB2srmUp3i3jF0AmuSzsDR2aUM iMeTAh1NTESHP85GkQ7QupsxGsiJ+cbdS+i8Z6pFRozT6+7XJ+ovd1Ac+GdzLSQEpJ3N7RNs993 YcBgb5gRmeJfHOTLT72mCU9y1 X-Received: by 2002:a05:6402:1352:: with SMTP id y18mr3823757edw.378.1607016993714; Thu, 03 Dec 2020 09:36:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZtf7leIUjlCKW3mVpZK5Zf5Gzy0qRNmOzFPFv7FInmFiAzlC18SOvJCT9vjRyuy5VZMtFxw== X-Received: by 2002:a05:6402:1352:: with SMTP id y18mr3823731edw.378.1607016993456; Thu, 03 Dec 2020 09:36:33 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j7sm1672932edp.52.2020.12.03.09.36.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 09:36:32 -0800 (PST) Subject: Re: [PATCH 1/1] KVM: x86: ignore SIPIs that are received while not in wait-for-sipi state To: Maxim Levitsky , kvm@vger.kernel.org Cc: Sean Christopherson , Joerg Roedel , Ingo Molnar , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Vitaly Kuznetsov , Borislav Petkov , Jim Mattson , Wanpeng Li , linux-kernel@vger.kernel.org, Thomas Gleixner References: <20201203143319.159394-1-mlevitsk@redhat.com> <20201203143319.159394-2-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <62e9c59f-29a4-d69f-5d02-a5da11cdbd15@redhat.com> Date: Thu, 3 Dec 2020 18:36:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201203143319.159394-2-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/20 15:33, Maxim Levitsky wrote: > In the commit 1c96dcceaeb3 > ("KVM: x86: fix apic_accept_events vs check_nested_events"), > > we accidently started latching SIPIs that are received while the cpu is not > waiting for them. > > This causes vCPUs to never enter a halted state. > > Fixes: 1c96dcceaeb3 ("KVM: x86: fix apic_accept_events vs check_nested_events") > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/lapic.c | 15 ++++++++------- Indeed, it was done by the xchg before that commit, even if vcpu->arch.mp_state != KVM_MP_STATE_INIT_RECEIVED. Paolo