From: Guenter Roeck <linux@roeck-us.net>
To: YueHaibing <yuehaibing@huawei.com>,
jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com,
andrew@aj.id.au
Cc: linux-aspeed@lists.ozlabs.org, alistair@popple.id.au,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-fsi@lists.ozlabs.org
Subject: Re: [PATCH -next] fsi: aspeed: Use devm_kfree in aspeed_master_release()
Date: Mon, 11 Nov 2019 06:16:06 -0800 [thread overview]
Message-ID: <62eacd00-300c-bc3e-b680-605bd0b7a983@roeck-us.net> (raw)
In-Reply-To: <20191109033209.45244-1-yuehaibing@huawei.com>
On 11/8/19 7:32 PM, YueHaibing wrote:
> 'aspeed' is allocted by devm_kfree(), it should not be
> freed bt kfree().
>
> Fixes: 1edac1269c02 ("fsi: Add ast2600 master driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/fsi/fsi-master-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
> index 3dd82dd..0f63eec 100644
> --- a/drivers/fsi/fsi-master-aspeed.c
> +++ b/drivers/fsi/fsi-master-aspeed.c
> @@ -361,7 +361,7 @@ static void aspeed_master_release(struct device *dev)
> struct fsi_master_aspeed *aspeed =
> to_fsi_master_aspeed(dev_to_fsi_master(dev));
>
> - kfree(aspeed);
> + devm_kfree(dev, aspeed);
> }
>
> /* mmode encoders */
>
The memory is attached to the device, and will thus be freed once the device
is released. Why is the release function needed in the first place ?
Guenter
prev parent reply other threads:[~2019-11-11 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 3:32 [PATCH -next] fsi: aspeed: Use devm_kfree in aspeed_master_release() YueHaibing
2019-11-09 3:36 ` [PATCH v2 " YueHaibing
2019-11-11 14:17 ` Guenter Roeck
2019-11-12 3:47 ` [PATCH v3 -next] fsi: aspeed: Fix aspeed device free YueHaibing
2019-11-11 14:16 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62eacd00-300c-bc3e-b680-605bd0b7a983@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).