linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Stone <jistone@redhat.com>
To: Kees Cook <keescook@chromium.org>,
	James Morris <james.l.morris@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] Yama: allow access for the current ptrace parent
Date: Mon, 5 Dec 2016 11:13:46 -0800	[thread overview]
Message-ID: <62fd5b15-5d1c-d834-97f9-2f6373dc7279@redhat.com> (raw)
In-Reply-To: <CAGXu5jKcx028GkcqsDzHBb4iWH-u2_jo5_4SrkB36gb8OpW_Hw@mail.gmail.com>

On 12/02/2016 03:27 PM, Kees Cook wrote:
>> +       /* If there's already an active tracing relationship, then make an
> 
> I'll adjust the comment style here and add it to my tree for -next.

Thanks!

I guess the tweak is that it should have an empty "/*" line?

FWIW, checkpatch.pl doesn't warn about this -- perhaps it should?
I only see the opposite check for NETWORKING_BLOCK_COMMENT_STYLE.

  reply	other threads:[~2016-12-05 19:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01  1:24 [PATCH] Yama: allow access for the current ptrace parent Josh Stone
2016-12-02 23:27 ` Kees Cook
2016-12-05 19:13   ` Josh Stone [this message]
2016-12-05 19:38     ` Kees Cook
2016-12-02 23:49 Kees Cook
2016-12-05  0:13 ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62fd5b15-5d1c-d834-97f9-2f6373dc7279@redhat.com \
    --to=jistone@redhat.com \
    --cc=james.l.morris@oracle.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).